GNOME Bugzilla – Bug 402187
[PATCH] Missing linked libraries for browser plugin
Last modified: 2007-02-07 07:52:41 UTC
The browser plugins need libstartup-notification, which is missing from the linking flags passed to them. Additionally, the XPCOM links are missing as well. The attached patch should fix the issues.
Created attachment 81460 [details] [review] totem-2.17.5-browser-plugin.patch
That looks wrong. The browser plugins certainly don't need to be linking to libstartup-notification, given that they don't use it (totem-plugin-viewer is, and does), and the rest of the "missing" XPCOM links should be resolved at run-time. What were the actual problems encountered?
Hmm, I think I made the libstartup-notification a bit too wide in application, however it is needed for totem-plugin-viewer. It not only includes the header, but calls functions from it (sn_launcher_context_get_startup_id fex). As for the XPCOM links, it results in the browser plugin failing to run and crashing Firefox.
A quick second glance at the patch reveals that the SN_{LIBS,CFLAGS} are being added only to the totem-plugin-viewer, which is the component which requires it.
(In reply to comment #3) > Hmm, I think I made the libstartup-notification a bit too wide in application, > however it is needed for totem-plugin-viewer. It not only includes the header, > but calls functions from it (sn_launcher_context_get_startup_id fex). Are you compiling the GTK+ only version? If so, it looks like it's missing from the GTK+ checks. The GNOME version is already pulling it through gnome-desktop > As for the XPCOM links, it results in the browser plugin failing to run and > crashing Firefox. Please file a bug against the browser plugin, and quote which version of Mozilla/Seamonkey/etc. you're compiling against, and against which you're running.
I guess the xpcom lib problem is bug 351266 ?
Yeah, its the same as bug #351266 I do believe. Marking this as a duplicate as such. *** This bug has been marked as a duplicate of 351266 ***