After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 401939 - [eog-ng] Remove leaftag support.
[eog-ng] Remove leaftag support.
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-29 02:41 UTC by Claudio Saavedra
Modified: 2007-01-30 00:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Claudio Saavedra 2007-01-29 02:41:55 UTC
Currently, the eog-ng branch has support to open files tagged with leaftag from the command line. I've not seen much work in leaftag itself, and wonder if we really want it in the core eog.

FWIW, I have the feeling no one has tested eog's leaftag support, because in main.c:137 the call to eog_application_open_tag_list () doesn't match its declaration (which was updated by the add for the startup flags). This compilation error has been hidden by the HAVE_LEAFTAG conditional compilation flag.

libleaftag itself, has not been developed since last july[1], so I am more and more convinced we don't want this into the core.

Comments?

[1] http://osiris.chipx86.com/svn/osiris-misc/trunk/libleaftag/ChangeLog
Comment 1 Lucas Rocha 2007-01-29 19:16:11 UTC
Agreed. I implemented this having in mind that leaftag would get some momentum. However this was not the case. You can remove it.
Comment 2 Claudio Saavedra 2007-01-30 00:39:50 UTC
Ok. Removed from SVN. Hopefully we can make it a plugin someday.

2007-01-29  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * configure.ac:
        * src/eog-application.c:
        * src/eog-application.h:
        * src/main.c: (main):

        Remove support for opening files tagged with leaftag. Unfortunately,
        leaftag has not seen the expected momentum, so it's preferable to leave
        it out of the core. Fixes bug #401939.