After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 401754 - Port Hue, Saturation, Value to CIE LCH
Port Hue, Saturation, Value to CIE LCH
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
unspecified
Other All
: Normal enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-01-28 17:33 UTC by Pucelo
Modified: 2016-08-29 20:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pucelo 2007-01-28 17:33:26 UTC
Hello! I have tried GIMP 2.3.14 in Windows (very thanks for develop it!) and it
have a important feature: descompose plugin has a HSL color mode. This color
mode is diferent of HSV model, because it splits saturation and lightness (and color, but this is done by HSV).

My idea is add two new modes in layer modes list: they are saturation and
lightness based on HSL model.

There are four options in the list (tone, saturation, color and value), it works in HSV color model. My idea is add two new options (saturation and
lightness), that will work different, and some people thinks that is better than HSV.
I think that programers will can get some code of new HSL patch (for compose/decompose plugin) and put it in the code of this new layer modes.

I mean some like this (note that the HSV options are NOT removed or replaced), this is the layer modes list:

| ...               |
|-------------------|
|Tone               |
|Color              |
|HSV saturation     |
|HSV value          |
|HSL saturation     |
|HSL lightness      |
---------------------
I think that HSL works better than HSV.

Sorry for the other feature request bad posted, and for my bad english.
Thanks for develop GIMP!!
Comment 1 Joao S. O. Bueno 2007-02-05 13:32:09 UTC
Creating more layer modes, in the GIMP as it is today, will risk to clutter the UI beyond usage and still not cover all ossible usages.

I, since a long time, envision a GIMP capable of using all new layer modes on the fly. 

The GEGL when used as an engine should add this ability, and this is being tracked at Bug #161449.

However even after that is implemented, and GEGL is used widespread inside teh GIMP, a UI for custom layer modes will need to be written. Thes surely will have a default layer mode listing, and the proposed modes could certainly be there.
Comment 2 Jesper de Jong 2007-11-26 18:38:26 UTC
See bug #325564
Comment 3 Martin Nordholts 2009-08-02 09:52:48 UTC
We won't add these new layer modes, but we might port the existing ones to CIE LCH when GEGL is used. Discussion on-going on gimp-developer, setting 2.8 milestone meanwhile. Also removing dependency to bug 161449 since the dependency doesn't exist any longer.
Comment 4 Martin Nordholts 2009-08-02 19:35:13 UTC
I've done this now:

commit 18603ac192493296b191197a3e2b62c710398afd
Author: Martin Nordholts <martinn@src.gnome.org>
Date:   Sun Aug 2 21:35:10 2009 +0200

    Bug 401754 – Port Hue, Saturation, Value to CIE LCH

    When using GEGL for the projection, use CIE LCH for the Hue,
    Saturation and Value layer modes, just as we already do for the Color
    layer mode. The Value layer mode will later be renamed to Lightness
    since that is the semantics it has now.

 app/gegl/gimpoperationpointlayermode.c |   63 +-------------------------------
 1 files changed, 1 insertions(+), 62 deletions(-)

Putting on the 2.10 milestone as a reminder to show the value layer mode as Lightness in the UI when we have finished the transition to GEGL.
Comment 5 Michael Natterer 2015-06-02 11:37:00 UTC
This bug is actually a duplicate, and fixed now.

*** This bug has been marked as a duplicate of bug 325564 ***
Comment 6 Michael Natterer 2015-06-02 16:46:07 UTC
Not a duplicate after all.
Comment 7 Elle Stone 2015-06-02 21:15:42 UTC
Originally bug 325564 was about replacing GIMP's HSV with HSL as used in PhotoShop. So the first 12 comments in bug 325564 are relevant to this bug. The Wikipedia article and notes also have good information: http://en.wikipedia.org/wiki/HSL_and_HSV. Trying to summarize some arguments on both sides:

In favor of adding HSL blend modes (like PhotoShop's) to GIMP:

1. Photoshop's HSL really is a lot better than HSV.
2. As per bug 325564, HSL allows GIMP users to follow PhotoShop tutorials on various blend modes.
3. HSL allows to provide hue locks for Curves. See
https://luminous-landscape.com/pdf/Curves.pdf
http://forum.luminous-landscape.com/index.php?topic=18413
http://simon.tindemans.eu/tools/tonability
4. As per bug 325564, HSL maps to PhotoShop's HSL blend modes when opening PhotoShop PSD documents.
5. If there's a place in the UI for more blend modes, as per Comment 1, and an easy way for the user to hide blends modes that aren't relevant to the user's particular workflow, then HSL would be a nice set of blend modes to have available.

Against adding HSL blend modes to GIMP:

1. HSL (like PhotoShop's) is much better than HSV. But neither is adequate to capture how we actually see colors, and neither allows to manipulate color and tonality completely independently. LCH blend modes produce results in keeping with how we actually see colors out there in the real world, and LCH allows to manipulate color and tonality separately.
2. GIMP users can write LCH blend mode tutorials, no doubt showing better results than you can get using HSL blend modes. I wouldn't be surprised to find that some of the PhotoShop tutorials work better with GIMP's LCH blend modes than with PhotoShop's HSL blend modes.
3. LCH also allows to provide hue locks when using Curves, though unlike the HSL blend modes, with LCH blend modes the user must be aware of possibly producing out of gamut colors (similar concerns affect Levels and other GIMP editing operations).
Comment 8 Alexandre Prokoudine 2015-12-03 14:30:51 UTC
Hi Pucelo. GIMP 2.9.2 is now released with LCH-based blend modes. Could you please try it and tell us if this is good enough for you? :)
Comment 9 Alexandre Prokoudine 2016-08-29 20:31:57 UTC
Closing as fixed.