Bug 400966 - Mute & unmute steadly decreases volume after repeated presses
Mute & unmute steadly decreases volume after repeated presses
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Jens Granseuer
Control-Center Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-01-26 11:39 UTC by Sebastien Bacher
Modified: 2007-02-01 22:56 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
round(volume) instead of floor(volume) when unmuting (728 bytes, patch)
2007-01-28 11:25 UTC, Jens Granseuer 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Sebastien Bacher 2007-01-26 11:39:08 UTC 
That bug has been opened on https://launchpad.net/ubuntu/+source/control-center/+bug/81203

"...
With the volume at maximum, pressing mute soft button repeatedly to switch between mute and unmute works fine.

With the volume control at anything less than maximum, pressing mute soft button repeatedly mutes, then as I press mute again, the unmute comes out of mute slightly lower volume than it was. So with the volume one notch below maximum then pressing the mute/unmute button 30 times results in the volume at the lowest level.

I know it sounds minor but it's not right.

http://librarian.launchpad.net/5838170/mute-unmute.ogg
mute-unmute.ogg

Confirmed on a second (desktop) machine.

Here, I made a video about it :)
..."

That happens with GNOME 2.17.90
Comment 1 Jens Granseuer 2007-01-28 11:25:30 UTC 
Created attachment 81362 [details] [review]
round(volume) instead of floor(volume) when unmuting
Comment 2 William Jon McCann 2007-02-01 19:48:13 UTC 
Bastien, this seems to fix it.
Comment 3 Bastien Nocera 2007-02-01 22:40:33 UTC 
Weird, but the patch looks fine to me.
Comment 4 Jens Granseuer 2007-02-01 22:56:32 UTC 
2007-02-02  Jens Granseuer  <jensgr@gmx.net>

        * actions/acme-volume-gstreamer.c:
        (acme_volume_gstreamer_set_mute): round volume instead of
        truncating on unmute so a simple mute/unmute doesn't lower the
        volume (fixes bug #400966)
Note You need to log in before you can comment on or make changes to this bug.