GNOME Bugzilla – Bug 400448
ruler subdivision is wrong for inches
Last modified: 2018-05-24 12:08:09 UTC
Hi, When showing INCHES, the ruler divisions are incorrect as it is divided using a decimal system. Please remember that In INCHES, you need to show demarcations at 1/16, 1/8, 3/16, 1/4, 5/16, 3/8, 7/16, 1/2, ... 7/8, 15/16 and 1 inch. As a reference, please go to http://www.thedollshousemall.com/paypal/044a%20%20%206%20inch%20ruler.jpg Hope this allows for The GIMP to become even better than it already is. Thanks for your contributions. Jorge
Well, sorry about that. But I don't think we are going to attempt changing the ruler widgets. We would rather remove all non-metric units.
I closed this because I considered it too much work, but I guess we can get away with calling gtk_ruler_set_metric(). If that doesn't do what is being asked for here, we can still close the bug or reassign it to GTK+ (where it would be closed then).
Seems to do what we want but we also have to change the ruler adjustments then. That code (gimp_display_shell_scale_setup()) could need some overhaul anyway. So if anyone wants to give it a try, feel free...
Given that GtkRuler has been deprecated and also removed from GTK+ 3, this is something to either try now or close as obsolete.
We copied it to GIMP as GimpRuler a long time ago. We can fix this in GIMP, even merge the fix to 2.8 if it still cleanly. Just need a volunteer :)
*** Bug 775907 has been marked as a duplicate of this bug. ***
Seriously don't mark this as obsolete. I'm certain every single GIMP user in the print industry is troubled by this. Please fix it or tell me how to recruit others who are willing.
It wasn't marked as obsolete, comment 5 still applies.
As for recruiting, you could spread a link to the bug and to the place where the ticks are drawn (https://git.gnome.org/browse/gimp/tree/libgimpwidgets/gimpruler.c) among your peers, with "If you want imperial inch subdivisions in gimp, here's how you can help: ..." text alongside of it. When trying to implement this, one will greatly benefit from knowing a bit of C and GTK+, and being able to build GIMP. If someone needs help, our IRC channel - #gimp on irc.gimp.org - is the best place to get it.
I too find this very troubling, since I always use the ruler for graph-measuring an image onto my canvas. It is impossible to do so with the Gimp ruler guidelines don't match my ruler. I wasn't even able to find a ruler with such increments to buy.
Yeah this should really be finally done. Also, it's an actual bug not an enhancement. And easily doable in 2.10.x is somebody wants to fix it.
Hello, the image from the original bug description is offline now. If I understand correctly, when in "inches" metrics, we don't want tenth divisions anymore, but 1/16, 1/8, 3/16, 1/4, is that it? Just a question, is there none at all who also needs inches division as currently done? I am wondering if there should be 2 versions of the inch ruler. Adding newcomers keyword because I don't think that would be hard to do.
Google helped: https://i.stack.imgur.com/uyWo0.jpg
As this patch shows, it's easily doable. We just need to collect subdivision rules for different units (inches, yards, whatnot), and add the right RulerMetric structs. commit fd37737fe4f3a7e84c1e0aff8ace24253250aa27 Author: Michael Natterer <mitch@gimp.org> Date: Mon Feb 12 12:20:32 2018 +0100 Bug 400448 - ruler subdivision is wrong for inches This commit changes nothing, but contains disabled proof-of-concept code to use different ruler subdivisions depending on the ruler's unit. libgimpwidgets/gimpruler.c | 91 +++++++++++++++++++++++++++++----------------- 1 file changed, 57 insertions(+), 34 deletions(-)
Created attachment 369058 [details] [review] Ruler subdivisions for imperial metric Hello, I wrote a small patch based on Michael comment 14. As I am not accustomed with imperial metrics, some further enhancements may be required, especially for feet and yards unit. Just have to update ruler_metric_feet and ruler_metric_yards. Maybe someone more knowledgeable can give some insight ?
Thanks Lionel, I pushed the patch, but changed the unit check to be a check on the unit's factor. Also kept the code disabled for double checking: commit 827d747fae65c0e347beb70bdc0655ce09555765 Author: Lionel N <lionel@libreart.info> Date: Tue Feb 27 20:28:50 2018 +0100 Bug 400448 - ruler subdivision is wrong for inches Add ruler subdivisions for feet and yards, the code is still disabled. libgimpwidgets/gimpruler.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)
Review of attachment 369058 [details] [review]: Pushed by Mitch.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/230.