After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400379 - Songs get imported more than once b/c of symlinks
Songs get imported more than once b/c of symlinks
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Importing
Legacy Branch
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 465353 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-24 21:20 UTC by Michael Monreal
Modified: 2008-03-30 02:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Monreal 2007-01-24 21:20:32 UTC
- import a directory => songs show up in library
- import that directory again => songs show up twice!
...

This should clearly not be the case and I think this was working fine in 0.10.x

(perhaps releated to 383151? anyway, much worse)
Comment 1 Michael Monreal 2007-06-13 19:42:23 UTC
This is still happening on trunk as of today.
Comment 2 Michael Monreal 2007-06-14 11:25:07 UTC
After looking at the DB I found the problem: my library location was set to $HOME/media/library, with $HOME/media being a link to /mnt/media. The first few thousand songs had the URI set to $HOME/media/library...... but at some point I suppose banshee started to use what's behind the symlink, so the later entries all had /mnt/media/......
Comment 3 Andrew Conkling 2007-08-23 15:22:18 UTC
I think this should be closed then.

For what it's worth, there is the Banshee cleanup library plugin here: http://code.google.com/p/banshee-cleanup-plugin. I expect this would clean up all old tracks with the old location.
Comment 4 Josiah Ritchie - flickerfly 2007-08-24 02:31:29 UTC
While the cleanup plugin solves the problem, it doesn't keep it from happening in the first place, which I expect to be the desired result. Plus, that is a 3rd-party plugin. Michael, are you still seeing this issue?
Comment 5 Michael Monreal 2007-08-24 07:34:19 UTC
Josiah: at some point I deleted my database because it was beyond repair, really (mostly due to podcasts, the plugin is totally broken and I really hope podcasts will get their own database in an upcoming version...)

But the main cause I described in comment 2 (taking a symlink VS taking the real path to the import folder) still causes the duplication. I think it would be quite easy to resolve symlinks and only use the real path in the DB.
Comment 6 Josiah Ritchie - flickerfly 2007-08-24 10:58:57 UTC
If someone could take the time to verify Andrew's symlink issue, I'll mark this new. If I get some time later, maybe I'll test it myself.

Okay(In reply to comment #5)
> Josiah: at some point I deleted my database because it was beyond repair,
> really (mostly due to podcasts, the plugin is totally broken and I really hope
> podcasts will get their own database in an upcoming version...)

I'm looking forward to a rewrite of the podcast plugin also. That seems to be a major plugin without a major amount of time available to be hacked on.

> But the main cause I described in comment 2 (taking a symlink VS taking the
> real path to the import folder) still causes the duplication. I think it would
> be quite easy to resolve symlinks and only use the real path in the DB.

How about I add the gnome-love keyword to this. Maybe someone will be interested in picking this one up.
Comment 7 Andrew Conkling 2007-08-24 13:17:16 UTC
Bug #421376 looks like a promising way to clean up the duplication, though I don't think it will fix the symlink problem.
Comment 8 Igor Guerrero Fonseca 2007-10-10 01:43:00 UTC
Please close this bug, it's fixed:

http://img62.imageshack.us/img62/3327/400379qa2.png

Banshee version: 0.13.1 in openSuSE 10.3 with a symlink to a folder in a NTFS partition(Banshee is great :)
Comment 9 Michael Monreal 2007-10-10 08:10:47 UTC
Igor Guerrero Fonseca: did you import from both /home/igor/Music and /mnt/whatever (where the nfs mount is)?
Comment 10 Igor Guerrero Fonseca 2007-10-10 23:07:30 UTC
Ahh no... importing the same folder from the same place...

I think I understand your request:

/home/user/Music/this - is a great song.ogg

is *equal* to:

/mnt/sda1/Music/this - is a great song.ogg

?

That's what you are trying to explain?

If that the case I'm not agree with the idea of tagging a song as the same some if they are in different locations.
Comment 11 Michael Monreal 2007-10-11 08:24:47 UTC
Yes, if /home/user/Music is just a link to /mnt/sda1/Music.
Comment 12 Igor Guerrero Fonseca 2007-10-11 23:44:52 UTC
But... it doesn't make any sense!

Lets wait for a Banshee main developer opinion.
Comment 13 Gabriel Burt 2008-03-26 00:01:46 UTC
*** Bug 465353 has been marked as a duplicate of this bug. ***
Comment 14 Andrew Conkling 2008-03-26 00:41:44 UTC
Is this happening in SVN trunk?
Comment 15 Igor Guerrero Fonseca 2008-03-26 03:58:25 UTC
I don't think this is a bug anyway... see the comments looks like the reported see a song twice but its because is the song in different locations I don't see anything bad in this.
Comment 16 Michael Monreal 2008-03-26 11:31:49 UTC
Then feel free to close...
Comment 17 Andrew Conkling 2008-03-26 11:37:16 UTC
(In reply to comment #16)
> Then feel free to close...

I was mostly looking for your word on this. :)