GNOME Bugzilla – Bug 397305
Provide a Tango style application icon for Sound capplet
Last modified: 2007-06-29 17:50:51 UTC
The current icon for Sound capplet in control center is using wrong style (old GNOME instead new Tango).
Maybe we should also change its name and use the same name of the executable or
something like "preferences-desktop-sound" (see Icon Naming Spec).
The Icon Naming Spec defines "preferences-desktop-multimedia". Is this the proper icon for this capplet?
Note there is also "Multimedia System Selector" capplet from gnome-media.
The "multimedia system selector" capplet and the "Sound" capplet should really be the same capplet.
In my current 2.17.x build the sound capplet has most (all?) of the multimedia system selector stuff build-in, so I guess we can forget about the multimedia system selector.
The Multimedia Selector shouldn't even have a .desktop. I filed bug 408292 about it.
As per results of #408292, closing as 'not a bug'.
Hmm, we removed the Multimedia Systems Selector from the menus, but does the Sound capplet have a new icon then?
I didn't realise there's two. The sound capplet is for configuring sounds for events only?
As well as which device is used for which function (ie. play movies on this device, etc.)
Created attachment 82684 [details]
screenshot of the current capplet icon
Yes, the launcher is called gnome-sound-properties and looks like the attached image.
(In reply to comment #3)
> In my current 2.17.x build the sound capplet has most (all?) of the multimedia
> system selector stuff build-in, so I guess we can forget about the multimedia
> system selector.
If you remove the multimedia system select capplet, please add a video capplet (since that is missing, like setup of a input device, selecting Xv adaptors, x/xv/SDL image output...).
(In reply to comment #10)
> If you remove the multimedia system select capplet, please add a video capplet
> (since that is missing, like setup of a input device, selecting Xv adaptors,
> x/xv/SDL image output...).
Any discussion on this matter belongs in a separate bug. The multimedia capplet was part of gnome-media anyway, and not gnome-control-center. Also see the recent "Removing the Multimedia Systems Selector from the menus" thread on desktop-devel-list for reasons for wanting to remove it.
Created attachment 82753 [details]
Hi, find attached tangoified gnome-sound-properties icon. The archive contains all required sizes (with 48x48 as scalable).
Created attachment 82758 [details]
I forgot to make 24x24 so here is the complete package
Created attachment 82886 [details]
gnome-sound-properties in gray
The colour of the reproductor has been changed on Jimmac's request to make it look more realistic.
(In reply to comment #14)
> Created an attachment (id=82886) 
> gnome-sound-properties in gray
> The colour of the reproductor has been changed on Jimmac's request to make it
> look more realistic.
Good to me. Both the speaker and the floating note are well fitted to represent features of this capplet.
Can we commit on svn or are we blocked by some freeze?
Created attachment 83100 [details] [review]
Patch to use "gnome-sound-properties" named icon in .desktop file and in source
Here is the patch to use the name of the binary file as icon for Sound capplet (.desktop file and window icon).
Note that currenlty the .desktop file is named "gnome-settings-sound.desktop". Maybe we could rename it "gnome-sound-properties.desktop".
The icons looks great, any particular reason on why they are not in yet?
Don't we want a 48x48 png as well? Also, should we distribute all the sizes?
No, the scalable icon targets 48x48, no need for a bitmap of this. 16x16, 22x22, 24x24 and 32x32 bitmap and the scalable version should be installed
I thought the idea was to not have to use svg. Anyway, what's with the gnome-settings-sound icon from gnome-icon-theme? Should these icons be added to the icon theme package or control-center? What's the reasoning here?
Right, they should be in G-I-T as "preferences-desktop-sound" (and gnome-settings-sound a link to that) because they are in the naming spec. The tango reference theme for example also has that icon. Perhaps re-assign to gnome-icon-theme now?
There is no preferences-desktop-sound in the latest naming spec - http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html. Please ship with the applet.
CVS HEAD of icon-naming-utils still has it:
and also tango-icon-theme ships this icon...
There have been a few icons in the naming spec that were removed over time. The naming spectriesto define a minimal set of icons that each icon theme authorshould aim to cover. The larger it is, the less likely it is theme authors will get full coverage.
To be honest, the apps context is still huge and I don't even think it should be themeable. You're right about tango icon theme shiping a few icons that aren't defined in the naming spec. Nevertheless control center applets should ship their icon artwork.
Ok, committed. Thank you Josef, Luca.
I guess the old icon can be removed from g-i-t now.
2007-06-28 Jens Granseuer <email@example.com>
Patch by: Luca Feretti <firstname.lastname@example.org>
* sound-properties-capplet.c: (main): use new icon name (patch from bug
2007-06-28 Jens Granseuer <email@example.com>
add new icons by Josef Vybíral (closes bug #397305)
Jens, looking at the attached changelog I think you included the svgs alone, for gnome-icon-theme we ship png for anything but the scalables, and in case of installation in the hicolor theme I think it's better to install the "scalable" in the 48x48 dir. If I'm wrong forgive me.
Nothing to forgive here. The prepare-ChangeLog script apparently didn't pick up the PNGs for some reason (and I blindly trusted it...), but there are in svn.
Just so I understand the rationale (the icon stuff is pretty alien to me): Why should the svg be installed in the 48x48 category?
Jens, I think you did it right. gnome-icon-theme also does it the way you do it. AFAIK the SVG icons in scalable should be done on 48x48.
Can you also commit the tango icons in bug 399051 and bug 375230