GNOME Bugzilla – Bug 397253
Disabled applets should hide/show automatically if existing on the panel
Last modified: 2020-11-06 20:23:57 UTC
Please describe the problem: When adding/removing and applet from the disabled_applets list gconf key, the panel should either hide/show to the respective applets instantly if they exist on the panel. Steps to reproduce: 1. add Geyes to the panel 2. using gconf-editor Add "OAFIID:GNOME_GeyesApplet" to the gconf key apps/panel/general/disabled_applets 3. when you click OK in the update key dialog, geyes should dissappear from the panel automatically. Actual results: nothing, the applet is untouched if existing on the panel, it only gets hidden/shown if you restart the panel Expected results: Applets should hide/show on the panel Does this happen every time? Yes Other information:
Created attachment 80397 [details] [review] Proposed patch
Created attachment 91622 [details] [review] Patch applies to lastest svn
Created attachment 116877 [details] [review] 2.23.6 patch Created new patch which applies to latest svn (2.23.6ish).
Created attachment 133962 [details] [review] second patch needed When using the previous patch, the build now fails when linking gnome-desktop-item-edit the build fails with the following error: ld: fatal: symbol `panel_gconf_get_client' is multiply-defined: (file gnome-desktop-item-edit.o type=FUNC; file panel-gconf.o type=FUNC); ld: fatal: File processing errors. No output written to .libs/gnome-desktop-item-edit This is because the previous patch adds "#include launcher.h" (which inlcudes "applet.h" which includes panel-gconf.h) to panel-lockdown.h. So this patch is also needed for this feature to work properly. This second issue was previously reported as bug #543291, but since it really relates to this patch, I'm adding it here. Attached patch removed definition of panel_gconf_get_client() from gnome-panel/gnome-desktop-item-edit.c.
Gah, ignore the previous comment. That comment was meant for bug #394249. I got confused.
Created attachment 133966 [details] [review] updated patch Looking into this further, I notice that we have updated the patch which addresses *this* issue. Here is the latest patch we are using.
This patch apparently depends on the patch in bug 394249.
Oh, and it's wrong: panel_lockdown_notify_add/panel_lockdown_notify_remove should use panel_applet_refresh_state(), I guess. Also, if you update the patch, please use the panel coding style. It will make the review a bit easier.
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports in Bugzilla which have not seen updates for many years. If you can still reproduce this issue in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/ Thank you for reporting this issue and we are sorry it could not be fixed.