After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 396386 - in rtl locale, applets popup menu should be aligned to the right of the applet
in rtl locale, applets popup menu should be aligned to the right of the applet
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal trivial
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks: Hebrew
 
 
Reported: 2007-01-14 10:55 UTC by Yair Hershkovitz
Modified: 2015-03-24 13:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Patch that should work (2.42 KB, patch)
2007-01-14 15:53 UTC, Vincent Untz 		committed Details | Review

Description Yair Hershkovitz 2007-01-14 10:55:22 UTC 
Please describe the problem:
Currently the popup is shown from the cursor position or applet left most point to the left.

When in an RTL locale, the popup should be shown from the cursor position or applet right most position to the right.

It looks very wierd when using a really wide applet such as the windows selection.
You click the mouse on the right most point of the applet, and the popup shows on
the other side of the panel.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Yair Hershkovitz 2007-01-14 10:57:06 UTC 
Please do exchange the occurances of "to the right" and "to the left"
Comment 2 Vincent Untz 2007-01-14 15:53:35 UTC 
Created attachment 80243 [details] [review]
Patch that should work
Comment 3 Vincent Untz 2007-01-14 15:54:10 UTC 
yair: could you test this patch? It should work, but I'm having troubles with my setup so I can't test it.
Comment 4 Vincent Untz 2007-01-14 16:17:45 UTC 
I forgot to ask: is the current behavior okay on vertical panels? I'd expect it is.
Comment 5 Yair Hershkovitz 2007-01-14 20:47:40 UTC 
I'll test it tomorrow. 

About vertical panels, i'm not sure. That depends if applets use the RTL property only on Horizontal panels. I think RTL behavior on vertical panel is still open to discussion.
Comment 6 Yair Hershkovitz 2007-01-15 07:10:28 UTC 
Patch tested, works great.

Also, Vertical panel behavior is just fine as it is.
Comment 7 Vincent Untz 2007-01-15 08:43:52 UTC 
Thanks