After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395708 - [telepathy] Crash when saving accounts
[telepathy] Crash when saving accounts
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: Telepathy
0.20
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
: 397220 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-12 08:33 UTC by Xavier Claessens
Modified: 2007-03-04 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (945 bytes, patch)
2007-01-14 18:47 UTC, Sjoerd Simons
none Details | Review

Description Xavier Claessens 2007-01-12 08:33:54 UTC
I was editing an IRC account.
1) Write something in the password entry
2) remove what you wrote
3) select another entry

AccountManager: Saving accounts
AccountManager: Saving file:'/home/zdra/.gnome2/Gossip/accounts.xml'

** (gossip:14867): WARNING **: GossipAccount has no parameter named `Password:'

** (gossip:14867): WARNING **: GossipAccount has no parameter named `Sans'

Program received signal SIGSEGV, Segmentation fault.

Thread NaN (LWP 14867)

  • #0 account_widget_generic_save_foreach
    at gossip-account-widget-generic.c line 88
  • #1 IA__g_list_foreach
    at glist.c line 495
  • #2 account_widget_generic_save
    at gossip-account-widget-generic.c line 107
  • #3 account_widget_generic_entry_focus_cb
    at gossip-account-widget-generic.c line 122
  • #4 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #5 IA__g_closure_invoke
    at gclosure.c line 490
  • #6 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #7 IA__g_signal_emit_valist
    at gsignal.c line 2209
  • #8 IA__g_signal_emit
    at gsignal.c line 2243
  • #9 gtk_widget_event_internal

Comment 1 Sjoerd Simons 2007-01-14 18:47:16 UTC
Created attachment 80259 [details] [review]
Proposed patch

The crash is because the string attached to the object is freed before the callback is executed.. Causing odd crashes. Copying the string and freeing after the object has gone away fixes the issue.. This patch also moves some duplicated code in both branched to the common path
Comment 2 Xavier Claessens 2007-01-15 19:49:18 UTC
committed, thanks !
Comment 3 Xavier Claessens 2007-01-16 12:03:33 UTC
*** Bug 397220 has been marked as a duplicate of this bug. ***