After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395644 - rhythmbox imports files adjacent to added files when modified
rhythmbox imports files adjacent to added files when modified
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.9.7
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-12 01:22 UTC by Ed Catmur
Modified: 2007-01-31 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rhythmdb_directory_change_cb-dont-add-hidden-or-siblings.patch (3.14 KB, patch)
2007-01-12 18:20 UTC, Ed Catmur 		committed Details | Review

Description Ed Catmur 2007-01-12 01:22:26 UTC 
1. Create ~/foo/Green.ogg, ~/foo/Red.ogg
2. Add ~/foo/Green.ogg to rhythmdb (Music->Import File)
3. Touch ~/foo/Red.ogg

Result: ~/foo/Red.ogg is added to rhythmdb.
Comment 1 Jonathan Matthew 2007-01-12 12:35:45 UTC 
When file monitoring is enabled, we intentionally monitor all directories containing files already in the library.
Comment 2 Ed Catmur 2007-01-12 16:57:48 UTC 
Why? If I added a file to the library, I want that file to be in the library, not all files in the same directory.
Comment 3 Ed Catmur 2007-01-12 18:20:57 UTC 
Created attachment 80127 [details] [review]
rhythmdb_directory_change_cb-dont-add-hidden-or-siblings.patch

Also fixes bug 395124.
Comment 4 James "Doc" Livingston 2007-01-13 23:41:46 UTC 
rb_uri_is_hidden() will segfault if it's passed a URI that doesn't have a '.' in it.
Comment 5 Ed Catmur 2007-01-14 00:34:29 UTC 
(In reply to comment #4)
> rb_uri_is_hidden() will segfault if it's passed a URI that doesn't have a '.'
> in it.

Um, it segs if passed a URI without a '/' in it.  Does such a thing exist?
Comment 6 James "Doc" Livingston 2007-01-14 00:40:30 UTC 
Err, never mind. My brain seems to have malfunctioned while reading the code.
Comment 7 James "Doc" Livingston 2007-01-31 09:44:40 UTC 
Committed to svn. Thanks.