After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393158 - GimpBrushSelectButton; brush selection dialog is not opened
GimpBrushSelectButton; brush selection dialog is not opened
Status: RESOLVED DUPLICATE of bug 356901
Product: GIMP
Classification: Other
Component: libgimp
git master
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-01-05 15:18 UTC by Kyoichiro Suda
Modified: 2007-01-05 20:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (1.77 KB, patch)
2007-01-05 15:19 UTC, Kyoichiro Suda
none Details | Review

Description Kyoichiro Suda 2007-01-05 15:18:11 UTC
Parameter -1 means no change, but PDB side is not known.
The setter of this object changes a property even if -1 is given.
Maybe it should be ignored.
Comment 1 Kyoichiro Suda 2007-01-05 15:19:47 UTC
Created attachment 79449 [details] [review]
fix
Comment 2 Sven Neumann 2007-01-05 19:49:24 UTC
I don't understand the description, please explain.
Comment 3 Sven Neumann 2007-01-05 20:27:11 UTC
Actually, this looks like a better fix for bug #356901. I will revert the change from two days ago, commit the patch and close this report as a duplicate.
Comment 4 Sven Neumann 2007-01-05 20:31:06 UTC
2007-01-05  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpbrushselectbutton.c: reverted the change for bug
	#356901 and instead applied a patch from Kyoichiro Suda that's
	actually a better fix and also plugs a memleak (see bug #393158).


*** This bug has been marked as a duplicate of 356901 ***