GNOME Bugzilla – Bug 392743
Can't finish poker
Last modified: 2021-06-02 11:32:46 UTC
Either I've not properly understood the rules, or Poker can't be finished. I've filled all the slots with cards. There are still cards in the stock, but I can't do anything with them. I can't move cards already placed. It appears that I can do nothing more, and the game is not giving me any indication that it's finished or what my score it.
You can read your score on the status bar (lower-right). It looks like this change http://svn.gnome.org/viewcvs/gnome-games/trunk/aisleriot/rules/poker.scm?rev=4309&r1=2947&r2=4309 had the unintended consequence of making it so the end-game condition would never have triggered. Before that change was made (I think), the game would have always ended when the last card was placed. I'm sure what the best thing is to do now because of two changes that were made since then: -To close the "end-game" dialog, you MUST start a new game or undo the last move. If you won, you must start a new game. -There's a "shuffle" variation where you can move the cards around after they're placed.
Yes, I can see the score and time in the status bar.
Patches anyone? :)
Before we can have patches, someone needs to come up with an acceptable behavior. The problem is that poker in shuffle mode gives you the option to move around the cards after they're set, meaning that, at least in shuffle mode, the game can never end until you're happy with your score and don't want to move the cards around anymore. If shuffle mode isn't activated, the game can end when all the cards are placed, but that wouldn't completely fix this bug.
Re-assigning to default owner.
Perhaps we can always just end the game when the last card is placed? The user can shuffle the cards around until then and still see the last card left in the "stack" (unsure about the terminology). It may be suboptimal for the first game but the user will quickly learn I think.
Created attachment 175334 [details] [review] patch to fix this for non-shuffle mode I'm still not satisfied with the shuffle mode behavior, but this should end the game in normal mode.
I've pushed the change. I think that for shuffle mode, the user should end the game in the normal way, by quitting or starting a new game. There's no reason the user should have to do something unusual to "end" the game, and there's no reason the user should have to quit when all cards are placed. Aisleriot should account for a condition where a game is both won and continuable. Starting a new game or quitting while a game is won should count as a win. Perhaps the status message should inform the player whether the game is currently won oslt.
Comment on attachment 175334 [details] [review] patch to fix this for non-shuffle mode Committed as 808df4f382685cd3bfbb9be714ec5893dfb42466
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/76.