After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 390834 - remember browser state/size
remember browser state/size
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other All
: Normal trivial
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 392071
 
 
Reported: 2006-12-29 23:42 UTC by Adam Zimmerman
Modified: 2007-01-17 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remember browser state (956 bytes, patch)
2006-12-29 23:43 UTC, Adam Zimmerman 		none Details | Review
working patch (15.86 KB, patch)
2007-01-16 10:18 UTC, Jonathan Matthew 		committed Details | Review

Description Adam Zimmerman 2006-12-29 23:42:08 UTC 
Please describe the problem:
This patch uncomments the functions do_impl_get_browser_key and do_impl_get_paned_key, so that the state of the browser will be remembered. There's a problem though: the browser appears when the source is first clicked on, so it appears squished to the left of the loading screen. Is there a way to cause rhythmbox to not restore the browser state until the catalogue is loaded?

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Adam Zimmerman 2006-12-29 23:43:04 UTC 
Created attachment 79052 [details] [review]
remember browser state

the loading screen issue needs to be addressed before this gets applied.
Comment 2 Guillaume Desmottes 2007-01-08 18:18:15 UTC 
I got the same problem with my Jamendo Plugin
Comment 3 Jonathan Matthew 2007-01-13 14:38:42 UTC 
The approach I'm taking is to add a method on the browser source class to allow subclasses to control the packing of the GtkPaned containing the browser and the entry view.  The default implementation just packs it into a box and adds that to the source widget.  Sources with loading screens can do the same, but also hold on to a reference to the box in order to hide it while the loading screen is displayed.

We also need to do some work on the python bindings to allow python sources to implement get_browser_key and get_paned_key.
Comment 4 Jonathan Matthew 2007-01-16 10:18:06 UTC 
Created attachment 80373 [details] [review]
working patch

also changes the gconf default for magnatune/show_browser to true (bug 392071)
Comment 5 Jonathan Matthew 2007-01-17 22:12:47 UTC 
committed to svn.