After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 390643 - Please add support for DAAP smart playlists
Please add support for DAAP smart playlists
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: DAAP
0.9.6
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-29 11:30 UTC by Julien Valroff
Modified: 2018-05-24 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add the missing 'aeSP' content code in the hard-coded dictionary. (887 bytes, patch)
2007-08-27 10:21 UTC, Jay L. T. Cornwall
none Details | Review
Fix last upload. (1.18 KB, patch)
2007-08-27 10:44 UTC, Jay L. T. Cornwall
committed Details | Review

Description Julien Valroff 2006-12-29 11:30:30 UTC
Hi,

I (and obviously other users) would be really grateful if you can add support for DAAP smart playlists in rhythmbox. There are 2 points here imho:

1/  Rhythmbox smart playlists should consider audio files stored in a shared library (not only from the main library)

2/ I use mt-daapd as a DAAP server, and there is a possibility to manage the smart playlists on the server side. These playlists are ignored by rhythmbox, whereas other players, eg. banshee, load them correctly.
mt-daapd also can parse existing static playlists stored on the server, and they are loaded by rhythmbox, which lets me think the support of dynamic playlist is just a question of time.

Thanks for your work!

Cheers,
Julien
Comment 1 Alex Lancaster 2006-12-29 11:52:02 UTC
For (1), that might be quite complicated and would require some thought as to how it should work and the UI required.

Regarding (2), rhythmbox will load all the playlists from the DAAP server, including smart playlists as they were at the time of opening the share.  If it doesn't it's a bug.  What it won't do is dynamically update the playlists on the client side if they are changed on the server side.  That is bug #344616
Comment 2 Julien Valroff 2006-12-29 12:12:43 UTC
Ok for (1), I think it would be great for users, like me, who do not use any local library, maybe you could have some thoughts for the next releases.

As for (2), then, it's a bug. Maybe I should report it against the Debian BTS as this may be linked to the way the Debian package is built.

Static playlists are loaded and processed, while smart playlists are not. However, they are loading ok from banshee, which lets me think it is not related to the server configuration.

Cheers,
Julien
Comment 3 T. Koehler 2007-04-20 19:43:13 UTC
I can confirm this bug in the same configuration, now still present in rhythmbox 0.10.0 as shipped with Ubuntu Feisty (7.04):

Smart playlists shared by mt-daapd are not showing up, even if present before connecting to server. I will try to confirm for other daap-servers that can share smart playlists, too.

Is this maybe due to the fact that they do not have a count of songs transmitted? I don't know about rhythmbox coding, but in PythonDAAP, the count field is NULL.
Comment 4 T. Koehler 2007-04-23 19:06:29 UTC
I found out that in rb-daap-connection.c, in function handle_playlists, the "name" is found as NULL for smart playlists - why that might be is beyond my skills, in python (PythonDAAP) retrieving the name works without problems.
Comment 5 Jay L. T. Cornwall 2007-08-27 10:21:09 UTC
This bug is caused by the 'aeSP' (com.apple.itunes.smart-playlist) DAAP content code missing from Rhythmbox's dictionary.

The dictionary should be sourced from the DAAP server at /content-codes but Rhythmbox appears to have a hard-coded dictionary at the moment. I've put together a patch to resolve this, simply adding in the offending content code, but it is not future-proof: Rhythmbox really should be building a dynamic dictionary.

Patch is attached.
Comment 6 Jay L. T. Cornwall 2007-08-27 10:21:59 UTC
Created attachment 94418 [details] [review]
Add the missing 'aeSP' content code in the hard-coded dictionary.
Comment 7 Jay L. T. Cornwall 2007-08-27 10:44:48 UTC
Created attachment 94419 [details] [review]
Fix last upload.

Patch was missing a file. That's what you get for doing this half asleep. :)
Comment 8 Jonathan Matthew 2007-08-28 09:55:12 UTC
Committed (essentially untested) to svn.  Thanks.

I'll leave the bug open in case anyone wants to work on client-side smart playlists for DAAP.
Comment 9 Lee Aylward 2007-08-29 00:00:23 UTC
This works great for me. It has been bugging me for quite some time, so it is great to see it added! Any chance you could make the smart playlists re-sortable like other playlists?
Comment 10 Jay L. T. Cornwall 2007-08-29 05:30:32 UTC
That's on my list right after fixing streaming titles in DAAP-shared radio stations.
Comment 11 Jonathan Matthew 2007-08-29 09:36:39 UTC
Making DAAP playlists sortable would fall under bug 327042.  I don't think any of the discussion there takes DAAP smart playlists into account, though.  The problem of restoring the original order doesn't really apply there, so it's much simpler.
Comment 12 beerfan 2008-05-27 04:34:54 UTC
Isn't this bug closed? Playlist sorting is obviously a different bug.
Comment 13 Benedict Stein 2010-02-12 21:26:15 UTC
Hi, I've had a simliar but more base orientated Problem,
did anyone of you manage to create some kind of DAAP playlist locally ?

I've tried but wasn't successful
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/518877
Comment 14 GNOME Infrastructure Team 2018-05-24 12:14:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/296.