GNOME Bugzilla – Bug 390585
Clock game incorrectly ends with "success"
Last modified: 2011-10-09 16:12:16 UTC
Please describe the problem: The game ended with the following card layout ("X" is face-down): QQQQ JJJJ AAAA TTTT X222 9999 KKKK 3333 8888 4444 7777 5555 6666 and declared I won, but the last "two" was still face-down. This should have been a loss. Steps to reproduce: 1. Rather hard to do, but play the game enough to get a layout like the above. Actual results: You win Expected results: You should lose Does this happen every time? It's the first time I've run across this card layout Other information:
Re-assigning to default owner.
Technically, according to the help and according to the game rules, this is a win. The game is won when all cards are in the correct location based on their rank, regardless of whether they are face-up. Wikipedia says the goal is to reveal all cards. Perhaps we should change it to match.
Throughout the course of 10 games or so of Aisleriot's Clock game, I have encountered this bug twice. I was declared a winner when all the cards had not yet been revealed. I played the game sometimes growing up, and we played according to the rules that Wikipedia describes. I would strongly vote to have the Clock game's rules fixed to match Wikipedia's rules. The way the game is programmed now, I think that if all of the cards happened to be dealt in their respective piles, then the player would be declared a winner with all of the cards face-down, before any moves were completed. That's not much of a game.
Such a game is impossible, as aisleriot skips games that begin with no possible moves (which includes, I believe, initially won games). But I have no objection to changing the rules to match Wikipedia. I personally don't like that the win condition can depend on information that isn't visible. Unless Christian (or anyone who else who happens to be reading) has an objection, I'll make this change.
That's fine with me.
Maybe I should wait for 3.3.x, as it means a change in the documentation.
I think it's still early enough in the release cycle, but it's your decision.
Maan, Wikipedia's version of Clock is depressing. :( Anyway, pushed: commit 565bb5c7c2b062c40d4c1c58263db8e0cbd16da4 Author: Vincent Povirk <madewokherd@gmail.com> Date: Sun Oct 9 11:06:38 2011 -0500 clock: Change goal to revealing all cards.