After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 389314 - eog should use stock_print-setup from g-i-t for the "Page setup..." action
eog should use stock_print-setup from g-i-t for the "Page setup..." action
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-24 23:32 UTC by Claudio Saavedra
Modified: 2006-12-28 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use stock_print-setup for the "Page setup" (1000 bytes, patch)
2006-12-25 02:43 UTC, Thomas Andersen 		committed Details | Review
use stock_print-setup for the "Page setup..." (731 bytes, patch)
2006-12-25 02:44 UTC, Thomas Andersen 		committed Details | Review

Description Claudio Saavedra 2006-12-24 23:32:25 UTC 
This is a good gnome-love candidate. See #373863 to get the idea of how to fix it, and please generate two patches, one for HEAD and other for eog-ng branches.
Comment 1 Thomas Andersen 2006-12-25 02:41:43 UTC 
Following are two patches. The first for HEAD and second for eog-ng. Or at least so I hope. Please tell me if I have generated these wrong as I have never generated for anything but HEAD before.

By the way in eog-ng the text is "Page Setup...". In head there is not dots at the end. Should this be changed also?
Comment 2 Thomas Andersen 2006-12-25 02:43:31 UTC 
Created attachment 78869 [details] [review]
use stock_print-setup for the "Page setup"

For HEAD
Comment 3 Thomas Andersen 2006-12-25 02:44:22 UTC 
Created attachment 78870 [details] [review]
use stock_print-setup for the "Page setup..."

for eog-ng
Comment 4 Claudio Saavedra 2006-12-25 05:17:23 UTC 
Hi Thomas, 

(In reply to comment #1)
> Following are two patches. The first for HEAD and second for eog-ng. Or at
> least so I hope. Please tell me if I have generated these wrong as I have never
> generated for anything but HEAD before.

Both patches are correct, but I think we should add as a dependence gnome-icon-theme, to make sure we have these icons available. 


> By the way in eog-ng the text is "Page Setup...". In head there is not dots at
> the end. Should this be changed also?

That would be a plus :-)
Comment 5 Claudio Saavedra 2006-12-28 00:58:50 UTC 
Fixed in both branches. Thank you!

2006-12-27  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * configure.ac: Add dependence on gnome-icon-theme.
        * shell/eog-window.c: Use "print-setup" icon from g-i-t. Patch from 
        Thomas Andersen <phomes@gmail.com>. Fixes bug #389314.