After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 388728 - gnome-media fails; implicit dependence on libxml2 not silently provided by libbonobo anymore
gnome-media fails; implicit dependence on libxml2 not silently provided by li...
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: general
2.17.x
Other Linux
: Normal blocker
: 2.17.3
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 352191
 
 
Reported: 2006-12-22 20:07 UTC by Elijah Newren
Modified: 2007-01-06 18:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
A patch that works, but doesn't check for a specific libxml2 version (don't know if that's needed, or what version would be the minimum) (589 bytes, patch)
2006-12-22 20:08 UTC, Elijah Newren
none Details | Review
add xml dependency (3.18 KB, patch)
2006-12-27 22:01 UTC, Christian Kirbach
none Details | Review

Description Elijah Newren 2006-12-22 20:07:21 UTC
gnome-cd/display.h depends on libxml2, but configure.in does not check for this.  It used to be that libbonobo-2.0.pc (via libgnome-2.0.pc) would bring in this dependency, but no longer does due to the change in bug 352191.  This causes the following compiling error:

 gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -DORBIT2=1 -pthread -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include -I/opt/gnome2/include/libgnome-2.0 -I/opt/gnome2/include/orbit-2.0 -I/opt/gnome2/include/libbonobo-2.0 -I/opt/gnome2/include/gconf/2 -I/opt/gnome2/include/gnome-vfs-2.0 -I/opt/gnome2/lib/gnome-vfs-2.0/include -I/opt/gnome2/include/bonobo-activation-2.0 -I/opt/gnome2/include/libgnomeui-2.0 -I/opt/gnome2/include/libgnomecanvas-2.0 -I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/include/libart-2.0 -I/opt/gnome2/include/libbonoboui-2.0 -I/opt/gnome2/include/gnome-keyring-1 -I/opt/gnome2/lib/gtk-2.0/include -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/cairo -I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include -I../../cddb-slave2 -I/opt/gnome2/include/gail-1.0 -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include -I/opt/gnome2/lib/gtk-2.0/include -I/opt/gnome2/include/cairo -I/opt/gnome2/include/pango-1.0 -g -O2 -MT cddisplayaccessible.lo -MD -MP -MF .deps/cddisplayaccessible.Tpo -c cddisplayaccessible.c  -fPIC -DPIC -o .libs/cddisplayaccessible.o
In file included from cddisplayaccessible.c:29:
../display.h:14:25: libxml/tree.h: No such file or directory
../display.h:15:27: libxml/parser.h: No such file or directory
In file included from cddisplayaccessible.c:29:
../display.h:67: error: syntax error before "xmlDocPtr"
make[3]: *** [cddisplayaccessible.lo] Error 1
make[3]: Leaving directory `/export/home/b/newrenTemp/gnome/gnome-media/gnome-cd/access'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/export/home/b/newrenTemp/gnome/gnome-media/gnome-cd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/export/home/b/newrenTemp/gnome/gnome-media'
make: *** [all] Error 2

To fix, gnome-media should explicitly check for libxml2.  I will provide a patch in a minute that works, but not that I am no autotools guru; you may want to double check it.  (See also bug 387961)
Comment 1 Elijah Newren 2006-12-22 20:08:43 UTC
Created attachment 78808 [details] [review]
A patch that works, but doesn't check for a specific libxml2 version (don't know if that's needed, or what version would be the minimum)
Comment 2 Elijah Newren 2006-12-22 20:27:01 UTC
Quick fix to my description of why the bug was hidden before:  s/libbonobo-2.0.pc/libbonoboui-2.0.pc/ and s/libgnome-2.0.pc/libgnomeui-2.0.pc/ in my original comment.
Comment 3 Christian Kirbach 2006-12-27 18:39:40 UTC
I can see that failure, too

http://jhbuild.bxlug.be/builds/2006-12-26-0000/logs/gnome-media/#build
Comment 4 Christian Kirbach 2006-12-27 22:01:35 UTC
Created attachment 78959 [details] [review]
add xml dependency

my take (before I detected this report)

I am an autotools noob. ideas shamelessly stolen from another xml patch done by Elijah.
Comment 5 Marc-Andre Lureau 2007-01-05 11:00:24 UTC
"ping"
Bug still on SVN Head
Comment 6 Ronald Bultje 2007-01-06 18:08:13 UTC
I would prefer if libxml2 detection just failed gnome-cd, not the whole package.
Comment 7 Ronald Bultje 2007-01-06 18:36:34 UTC
2007-01-06  Ronald S. Bultje  <rbultje@gnome.org>

        * configure.in:
        * gnome-cd/access/Makefile.am:
          Explicit dependency on libxml2 (#388728).