GNOME Bugzilla – Bug 388702
pango 1.15.2 segfaults on Korean example from testgtk
Last modified: 2007-01-03 22:17:28 UTC
I'll attach a text file that crashes pango-view
Created attachment 78803 [details] korean text
Changwoo Ryu, this seems to be caused by your commit: 2006-12-20 Changwoo Ryu <cwryu@debian.org> * modules/hangul/hangul-defs.h: * modules/hangul/hangul-fc.c (hangul_engine_shape): Optimizing for non-old Hangul users; no more waste of decompose and compose. (render_syllable): The string argument is now in UTF-8. Normalization is now done only when the entire sequence is equivalent to a precomposed syllable. (render_isolated_tone): Conditioned out tone mark's dummy base character drawing. Can you fix the crash please? Matthias, can you do a pmap on the crashing process (inside gdb perhaps) to see which fonts it has opened? Thanks,
I tried a few different Hangul fonts but I couldn't reproduce the crash. Please let me know which font it used.
*** Bug 391860 has been marked as a duplicate of this bug. ***
Ok, I'll revert this change if no patch arrives in 24 hours. I want to release 1.16.0 in about a week and this is too late in the devel cycle to have a crasher hanging around.
(In reply to comment #4) > *** Bug 391860 has been marked as a duplicate of this bug. *** Thanks for looking at this and happy new year :) The crash happens when browsing to http://en.wikipedia.org/wiki/Teletext which seems to include tables of videotext glyphs (from what I see in links, firefox & epy just crash) The font was probably dejavu 2.13 Mono as it's the U+2500… block provider on my system (with some arial glyphs mixed in). After uninstalling it I still have a crasher (and now gucharmap says dejavu LGC 2.10 + Arial are responsible for this block) I don't know how to test further – the system won't let me uninstall LGC as OO.o depends on it
(In reply to comment #6) > I don't know how to test further – the system won't let me uninstall LGC as > OO.o depends on it Remove Arial temporarily? rpm -e --nodeps LGC, or mv/usr/share/fonts/dejavu-lgc /tmp temporarily.
Created attachment 79213 [details] stacktrace from testgtk crash
Created attachment 79214 [details] pmap output
(In reply to comment #7) > rpm -e --nodeps LGC, or mv/usr/share/fonts/dejavu-lgc /tmp temporarily. behdad, you're an evil man, but anyway removing every dejavu derivative & ms core fonts from the system still results in a crasher I haven't the faintest idea wha
t other font it may use to render this page
I see why I couldn't reproduce it... The problem seems to be in the fallback for the case that there was no font which has Hangul glyphs.
The patch from bug 388581 should resolve the crash: http://bugzilla.gnome.org/attachment.cgi?id=78794&action=view But this is not a duplicate of 388851. This crash let me know a more exceptional case, when there is "S+T" sequence and the font has no Hangul glyph. Patch coming.. Now I am moving to a new place and have a limited net access (thanks to svn allowing me to make patch with no connection). Please commit the patch and mark the bugs fixed, if it's ok.
Created attachment 79268 [details] [review] Proposed patch, including the fix for bug 388581
Oops, typo in the changelog. Please exclude the copy&pasted line..
Thanks. Nicolas, can you test the patch?
Thanks. That fixed it. 2007-01-03 Changwoo Ryu <cwryu@debian.org> Bug 388702 - Crash when there's no Hangul glyph in the font. * modules/hangul/hangul-fc.c (render_syllable): Do not try to render unknown syllable glyphs as jamos. * modules/hangul/hangul-fc.c (hangul_engine_shape): Check if the remaining string is a syllable. Bug 388581 - Every last Hangul syllable is decomposed to jamos. * modules/hangul/hangul-fc.c (hangul_engine_shape): Check if the remaining string is a syllable.
Forgot to close.
(In reply to comment #16) > Thanks. Nicolas, can you test the patch? I can confirm the fix BTW since caillon did a firefox 2 release after all could you point him to your ligature fix please?
(In reply to comment #19) > (In reply to comment #16) > > Thanks. Nicolas, can you test the patch? > > I can confirm the fix > > BTW since caillon did a firefox 2 release after all could you point him to your > ligature fix please? The fix is part of the printing patch. I'm sure he picks it up very soon if he's not already.