After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 388425 - two quick fixes for magnatune plugin
two quick fixes for magnatune plugin
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other All
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-21 22:14 UTC by Adam Zimmerman
Modified: 2007-01-13 05:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
year fix (1004 bytes, patch)
2006-12-21 22:15 UTC, Adam Zimmerman 		committed Details | Review
method name cleanup (3.11 KB, patch)
2006-12-21 22:16 UTC, Adam Zimmerman 		committed Details | Review

Description Adam Zimmerman 2006-12-21 22:14:34 UTC 
Please describe the problem:
1 - better handling of year field
- there are 2 date-related fields in song_info.xml. The year the album was released (year), and the date it was put on magnatune (launchdate). Some albums (mostly classical I think) have year 0, so previously, the plugin always used launchdate. This fixes it to use year unless it is <= 0.

2 - change buy_track and purchase_track to *_album
- the method names don't describe their functions very well. These names are slightly better

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Adam Zimmerman 2006-12-21 22:15:20 UTC 
Created attachment 78760 [details] [review]
year fix
Comment 2 Adam Zimmerman 2006-12-21 22:16:12 UTC 
Created attachment 78762 [details] [review]
method name cleanup

(since you can't buy individual tracks)
Comment 3 Jonathan Matthew 2007-01-13 05:07:15 UTC 
Committed to svn.  I had to modify the year fix a bit - it was trying to use the year as a julian date, so most things were showing up as being from the year 6.