GNOME Bugzilla – Bug 386113
show custom alarm message in pop-up alerts
Last modified: 2013-10-08 13:42:16 UTC
The "Edit Alarm" dialog offers a custom message field. However, when the alarm action is "Pop up an alert", the custom message is not actually seen in the pop-up alert. I get two alerts, actually: a brief notification bubble and a more complete dialog box with various controls. Neither one of these shows the custom message. This effectively renders the custom message useless. At least one (and perhaps both) of these pop-up alerts should show the custom message, if such a message is set for the given alarm.
Reproduced in evo 3.6 and 3.8
Created attachment 247261 [details] [review] evo patch for evolution; This chooses either alarms description as a notification summary, or components summary (as it used to before the patch), if the alarm description is not available or is empty.
Created attachment 247263 [details] [review] evo patch ][ for evolution; Err, this one is better, it doesn't cause (possible) use-after-free.
Created commit 3ecab2f in evo master (3.9.4+) Created commit 14c5324 in evo gnome-3-8 (3.8.4+)
I'm reopening this. It turned out that some backends (like CalDAV talking to certain servers) may have set a meaningless message on the alarm notification, thus Fidencio will add a check whether the backend supports custom alarm messages or not and will use it in alarm notify.
Created attachment 249802 [details] [review] Fix typo in e_cal_backend_file_get_backend_property() test-driver
Created attachment 249803 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts Enable this feature only for backends we are completely sure it works. Only enabled for local calendars (file backend) for now.
Created attachment 249804 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts
Created attachment 249805 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts
Comment on attachment 249804 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts Evolution
Comment on attachment 249803 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts Evolution Data Server
Comment on attachment 249805 [details] [review] Bug #386113 - show custom alarm message in pop-up alerts Evolution-EWS
Comment on attachment 249802 [details] [review] Fix typo in e_cal_backend_file_get_backend_property() There is a typo in the commit message, I'll delete it when I have an ACK to commit.
Review of attachment 249802 [details] [review]: Good catch, please commit. Thanks.
Review of attachment 249803 [details] [review]: Looks OK, please commit.
Review of attachment 249804 [details] [review]: Looks OK, please commit.
Review of attachment 249805 [details] [review]: And the same here, please commit. Thanks.
Created commit b7861eb and d611d25 in e-d-s master (3.9.5+) Created commit 86d11ac in e-d-s gnome-3-8 (3.8.4+) Created commit a152ad9 in evo master (3.9.5+) Created commit fe65256 in evo gnome-3-8 (3.8.4+) Created commit 76b762d in evo-ews master (3.9.5+) Created commit 765e6d3 in evo-ews gnome-3-8 (3.8.4+)
(In reply to comment #10) > (From update of attachment 249804 [details] [review]) > Evolution We forgot one change here, the alarm_queue_get_alarm_summary() should also check for the capability of the client, thus it'll use the alarm description only if the client supports it.
Created attachment 250008 [details] [review] Only use the alarm description if the client supports it
Review of attachment 250008 [details] [review]: Untested, but the alarm_queue_get_alarm_summary() is responsible to provide alarm description, wherever it finds it. Not calling the function means no description at all => needs-work.
Created attachment 250025 [details] [review] Only use the alarm description if the client supports it
Review of attachment 250025 [details] [review]: Right, this is better. I would not add the local variables for ECalClient, but that's just my way of work, not a rule :) Please add the additional change from below and commit to master and gnome-3-8. Thanks. ::: calendar/alarm-notify/alarm-queue.c @@ +1620,2 @@ } } to be 100% sure make the preceding line: } else { *palarm = NULL; }
Created commit 0ee86ee in evo master (3.9.5+) Created commit fea1a50 in evo gnome-3-8 (3.8.5+)
*** Bug 705114 has been marked as a duplicate of this bug. ***
One more follow-up commit for this bug report. It turned out that my understanding of the RFC when fixing this bug report was incorrect, the alarm description is not supposed to replace the component summary, but only extend it with an additional text. Thus let's show both component summary and alarm description in Reminders. Created commit c3c9ba6 in evo master (3.11.1+) Created commit 7cf439f in evo gnome-3-10 (3.10.1+)