GNOME Bugzilla – Bug 385543
Banshee doesn't have disc column
Last modified: 2008-04-10 06:02:28 UTC
Please describe the problem: I have albums with multiple discs, and when I try viewing the album in order in banshee, I get "Track 1", "Track 1", "Track 2", "Track 2", ... There should be a disc column in the main treeview to solve this problem. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
This will have to wait for 0.12.x as we're string and feature frozen.
*** Bug 406523 has been marked as a duplicate of this bug. ***
Created attachment 85911 [details] [review] Add discnumber to db and TrackInfo 2007-04-06 Pepijn vd Geer <pvandegeer@gmail.com> * src/Core/Banshee.Base/Database.cs: Add DiscNumber and DiscCount to DB. * src/Core/Banshee.Base/TrackInfo.cs: * src/Core/Banshee.Base/FileTrackInfo.cs: * src/Core/Banshee.Base/LibraryTrackInfo.cs: Add DiscNumber and DiscCount properties to the TrackInfo. * src/Core/Banshee.Base/StreamTagger.cs: Handle DiscNumber and DiscCount when importing from files.
Created attachment 85912 [details] [review] Add disc column to PlaylistView This patch adds the disc column to the playlistview. Obviously it depends on the other attachment in this bug. It works fine, but the column sorting isn't perfect yet. Can anyone give me some pointers on the ModelCompare stuff? Sorting on disc should probably keep artist, album and track sorted as well.
At first glance, this looks very good. Going to test it soon, but I don't expect much problems.
Created attachment 85947 [details] Mockup of discnumber in trackeditor Maybe this should be a seperate bug, but the trackeditor needs an entry for the discnumber. Maybe something like this?
Why is track number / total tracks made up of two rows and disc number / total disc only one in that mockup? I think we should choose one for consistency :-)
(In reply to comment #7) > I think we should choose one for consistency :-) For clarity, I meant "one of those", I'm not sure we should choose the two-rows way or the one-row way, just pick one way and stick with it. Not expressing any opinion there.
I think the better one is for the "of" format. It promotes clarity strengthens the relationship between the fields. It works out well in iTunes as well: http://www.cnet.com/i/hlp/itunes_edit_tag.jpg The main issue though, would be how to display this in multi-track editor mode.
Just to motivate my decision: I put them on one line, because I thougth the list would get to long otherwise. But I agree this is an inconsistency. IMHO the tracknumber/count should be on one line, also because the entryfields don't need that much room. Though I'm not sure how to handle multi-track editor mode in that case. One solution would be to remove the button on the right and add the same logic to the button on the left, which would than work on both fields (number and count) since they would be on the same line. ps. i've got a working patch to handle the disccount in the trackeditor. I'm just waiting for this issue to be resolved before I post it.
Created attachment 87271 [details] [review] Patch to add disccolumn This patch combines both previous patches and updates them to latest svn. It also addresses column sorting better. Sorting on Album also takes in account the discnumber and sorting on discnumber handles sorting of the other columns as well. * src/Core/Banshee.Base/Database.cs: Add DiscNumber and DiscCount to DB. * src/Core/Banshee.Base/TrackInfo.cs: * src/Core/Banshee.Base/FileTrackInfo.cs: * src/Core/Banshee.Base/LibraryTrackInfo.cs: Add DiscNumber and DiscCount properties to the TrackInfo. * src/Core/Banshee.Base/StreamTagger.cs: Handle DiscNumber and DiscCount when importing from files. * src/Core/Banshee/PlaylistView.cs: * src/Core/Banshee/Banshee.TrackView.Columns/TrackViewColumn.cs: * src/Core/Banshee/banshee-interface.schemas.in: Add new DiscNumber column. * src/Core/Banshee/Banshee.TrackView.Columns/DiscNumberColumn.cs: New. * src/Core/Banshee/Banshee.TrackView.Columns/AlbumColumn.cs: Also sort discnumber * src/Core/Banshee/Banshee.mdp: * src/Core/Banshee/Makefile.am: Update projectfiles for new DiscNumberColumn.cs.
Looks like the current patch is breaking the current trunk. I can compile just fine without the patch applied. Error is as follows: ./Banshee.PlayerMigration/RhythmboxPlayerImport.cs(132,43): error CS1501: No overload for method `Banshee.Base.LibraryTrackInfo' takes `11' arguments ./DBusRemote.cs(43,34): warning CS0219: The variable `nameReply' is assigned but its value is never used Compilation failed: 1 error(s), 2 warnings make[4]: *** [Banshee.Base.dll] Error 1 make[4]: Leaving directory `/home/mkoby/svn/banshee/src/Core/Banshee.Base' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/mkoby/svn/banshee/src/Core' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/mkoby/svn/banshee/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/mkoby/svn/banshee' make: *** [all] Error 2 Pity too, because I really need this patch, all my stuff is tagged with disc numbers for easier organization.
Still an issue currently.
*** Bug 472737 has been marked as a duplicate of this bug. ***
Unfortunately this never got reviewed/in for stable, and things are changed considerably in trunk. Sorry about that Pepijn, I feel terrible about that. I just added the Disc column to trunk, but we still need a patch to be able to edit it.