After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 383726 - [audiopanorama] only transforms half of the samples in float mode
[audiopanorama] only transforms half of the samples in float mode
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.5
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Reported: 2006-12-08 13:35 UTC by Sebastian Dröge (slomo)
Modified: 2006-12-08 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

audiopanorama.diff (2.19 KB, patch)
2006-12-08 13:36 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2006-12-08 13:35:41 UTC
currently audiopanorama only transforms one half of the samples when working in float mode. It can accept 16 bit int or 32 bit float samples, the num_samples calculation in the transform function only assumes 16 bit int samples.

Attached is a patch to fix this (by adding a new instance variable width). I decided to fix it this way because getting caps of the buffer, reading the structure of the caps and reading the width element of it would be unnecessary overhead in the transform function and it shouldn't change without calling the caps function anyway.

Comment 1 Sebastian Dröge (slomo) 2006-12-08 13:36:04 UTC
Created attachment 77959 [details] [review]
Comment 2 Wim Taymans 2006-12-08 16:38:57 UTC
        Patch by: Sebastian Dr��ge  <mail at slomosnail de >

        * gst/audiofx/audiopanorama.c: (gst_audio_panorama_init),
        (gst_audio_panorama_set_caps), (gst_audio_panorama_transform):
        * gst/audiofx/audiopanorama.h:
        Fix audiopanorame with float samples. Fixes #383726.