GNOME Bugzilla – Bug 383031
left/right confusion in menu item labels in RTL languages
Last modified: 2017-10-22 17:01:07 UTC
Move Tab to the left describe action "Shift+Ctrl+Page Up" (this shortcut move the tab to the right) Move Tab to the right describe action "Shift+Ctrl+Page Down" (this shortcut move the tab to the left) Other information: Move Tab to the right for "Shift+Ctrl+Page Up" Move Tab to the left for "Shift+Ctrl+Page Down"
I am sorry but I do not understand what you mean by this. Are you using a right-to-left locale?
Yes, this bug is related to arabic locale. The behaviour is not expected as it is described in menu.
Suggestion for fixing bug: # cp /usr/share/locale/ar/LC_MESSAGES/gnome-terminal.mo \ /usr/share/locale/ar/LC_MESSAGES/gnome-terminal.mo.orig # msgunfmt /usr/share/locale/ar/LC_MESSAGES/gnome-terminal.mo > /var/tmp/a.po # cat <<_EOF>>/var/tmp/a.po msgid "Move Tab to the _Left" msgstr "Move Tab to the _Right" msgid "Move Tab to the _Right" msgstr "Move Tab to the _Left" _EOF # msgfmt -o /var/tmp/a.mo -v /var/tmp/a.po # mv /var/tmp/a.mo /usr/share/locale/ar/LC_MESSAGES/gnome-terminal.mo # env LANG=ar_EG.UTF-8 gnome-terminal
Ah. The problem is that the ar translation is not complete, so you ar eseeing the English messages, intended to be used in a LTR locale. This will occur in any untranslated RTL language. The fix for this is to translate the strings, then.
Could you move the bug category into l10n/ar?
This is still the case for gnome-terminal for HEAD. But it does strike me that it is odd to reverse the meanings with translations in order to fix this. (Like Hanka suggested). It's easy to do that, but all RTL languages will need to do the same. Somehow this does not seem to be to be a proper fix. What do you think?
Seems Ok to me, as long as a translator comment is added to it. We've done otherwise in other places, but it's not a big deal. If someone wants to cook a patch either way, I can review that.
Created attachment 130467 [details] [review] Inverts the labels if an RTL locale is set Here is a fix using gtk_widget_get_direction.
IMHO as saner way would be to unify tabs_move_left_callback and tabs_move_right_callback callbacks into one, and do the direction based switching in there.
Makes sense. ChPe, will you be looking into this anytime soon?
No. It's not hard, already has gnome-love keyword; anyone can do it :)
I have some of this implemented (merging tabs_move_left_callback and tabs_move_right_callback into one), but I'd like some clarification on the labels issue. Is this about switching the labels depending on the text direction, or about changing the behaviour to match the label/action description?
Fixed with the gmenu port.