After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 382556 - Preferences dialog crashes when user supplies custom pattern.
Preferences dialog crashes when user supplies custom pattern.
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-05 10:15 UTC by Ruben Vermeersch
Modified: 2006-12-05 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
banshee-preferences-patterns.patch (2.69 KB, patch)
2006-12-05 10:16 UTC, Ruben Vermeersch 		none Details | Review
banshee-preferences-patterns.patch v2 (2.81 KB, patch)
2006-12-05 10:35 UTC, Ruben Vermeersch 		committed Details | Review

Description Ruben Vermeersch 2006-12-05 10:15:28 UTC 
When setting a custom naming pattern through gconf, the preferences dialog causes banshee to crash. Attaching a patch to prevent this.
Comment 1 Ruben Vermeersch 2006-12-05 10:16:21 UTC 
Created attachment 77718 [details] [review]
banshee-preferences-patterns.patch

 ChangeLog                                 |    6 ++++++
 src/Banshee.Base/Gui/PreferencesDialog.cs |   18 ++++++++++++++++++
 2 files changed, 24 insertions(+)


2006-12-05  Ruben Vermeersch  <ruben@savanne.be>

   * src/Banshee.Base/Gui/PreferencesDialog.cs: Allow users to specify
   custom LibraryFilePattern and LibraryFolderPattern preferences to gconf,
   yet don't crash in the preferences screen.
Comment 2 Ruben Vermeersch 2006-12-05 10:35:56 UTC 
Created attachment 77721 [details] [review]
banshee-preferences-patterns.patch v2

And here's one that applies cleanly, nothing changed otherwise.
Comment 3 Aaron Bockover 2006-12-05 16:43:18 UTC 
Cool, commit, provided you change "found" to "preference_already_added." If you have to provide a comment to describe a local variable, you've picked a bad name for that variable :)
Comment 4 Ruben Vermeersch 2006-12-05 18:35:30 UTC 
Good point about the naming, I've changed it :-). First real piece of C# in a long time, feels good to be back!