Bug 382503 - problematic filter function
problematic filter function
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-12-05 06:59 UTC by Matthias Clasen
Modified: 2007-01-31 17:33 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
do just what Matthias suggested (630 bytes, patch)
2007-01-07 17:23 UTC, Jens Granseuer 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Matthias Clasen 2006-12-05 06:59:26 UTC 
acme_filter_events() needs to check for the event type before assuming it is a key event. Something like 

        if (xev->xany.type != KeyPress &&
            xev->xany.type != KeyRelease)
          return GDK_FILTER_CONTINUE;
Comment 1 Jens Granseuer 2007-01-07 17:23:29 UTC 
Created attachment 79652 [details] [review]
do just what Matthias suggested

patch is against 2.17.3. Also removes an unused variable.
Comment 2 Jens Granseuer 2007-01-31 17:33:59 UTC 
Patch applied.
Note You need to log in before you can comment on or make changes to this bug.