After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 382277 - multipartmux modifies buffer timestamp
multipartmux modifies buffer timestamp
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-12-04 15:04 UTC by Jonas Holmberg
Modified: 2006-12-06 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Jonas Holmberg 2006-12-04 15:04:39 UTC
Please describe the problem:
gst_multipart_mux_queue_pads() modifies the timestamp of the buffer.

Steps to reproduce:
1. create buffer and set timestamp
2. send a buffer through multipartmux
3. check timestamp in original buffer

Actual results:
The timestamp of the original buffer has been modified.

Expected results:
The timestamp of the original buffer should not have been modified.

Does this happen every time?

Other information:
Doing gst_buffer_make_metadata_writable() before modifying the timestamp in gst_multipart_mux_queue_pads() solves the problem, *but* it is not the correct solution since multipartmux shouldn't modify the timestamp at all.
Comment 1 Wim Taymans 2006-12-06 14:46:07 UTC
        * gst/multipart/multipartmux.c: (gst_multipart_mux_compare_pads),
        (gst_multipart_mux_queue_pads), (gst_multipart_mux_collected):
        Keep track of the buffer timestamp in the collectdata member instead
        of modifying the buffer without making the metadata writable first.
        Fixes #382277.