GNOME Bugzilla – Bug 382277
multipartmux modifies buffer timestamp
Last modified: 2006-12-06 14:46:07 UTC
Please describe the problem:
gst_multipart_mux_queue_pads() modifies the timestamp of the buffer.
Steps to reproduce:
1. create buffer and set timestamp
2. send a buffer through multipartmux
3. check timestamp in original buffer
The timestamp of the original buffer has been modified.
The timestamp of the original buffer should not have been modified.
Does this happen every time?
Doing gst_buffer_make_metadata_writable() before modifying the timestamp in gst_multipart_mux_queue_pads() solves the problem, *but* it is not the correct solution since multipartmux shouldn't modify the timestamp at all.
* gst/multipart/multipartmux.c: (gst_multipart_mux_compare_pads),
Keep track of the buffer timestamp in the collectdata member instead
of modifying the buffer without making the metadata writable first.