After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 381196 - rhythmbox-client has no option to toggle shuffle/repeat
rhythmbox-client has no option to toggle shuffle/repeat
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Programmatic interfaces
0.9.6
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-01 08:58 UTC by Donn Morrison
Modified: 2012-12-08 07:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Donn Morrison 2006-12-01 08:58:11 UTC
It would be great if rhythmbox-client would have options to toggle shuffle/repeat like xmms does:

  -S, --toggle-shuffle[=OPTION]
  -R, --toggle-repeat[=OPTION]
  -A, --toggle-advance[=OPTION]

(From xmms --help)


Other information:
Comment 1 Alex Lancaster 2006-12-08 03:51:43 UTC
Seems sensible, confirming.
Comment 2 rderuiter 2008-08-29 12:01:38 UTC
Alright, i'd like to implement this feature. Although i could use some help since i'm not that familiar with the RB-code nor with D-Bus. Anyone i can contact for some pointers via mail or IRC perhaps?
Comment 3 Jonathan Matthew 2008-08-30 01:41:30 UTC
IRC: #rhythmbox on irc.gnome.org (depending on what time of day you ask, it can take several hours to get a response)
or the mailing list: rhythmbox-devel@gnome.org (best if you subscribe first)

The main thing involved in implementing this is adding dbus methods for getting and setting the repeat and shuffle settings.  I don't think we should expose the concept of named play orders (linear, linear-loop, shuffle, random-by-*) here, because I don't think it's a good concept.

These methods would be implemented using (or at least similarly to) rb_shell_player_get_playback_state and rb_shell_player_set_playback_state.  The code in rhythmbox-client should be straightforward.


Comment 4 Ross Lagerwall 2012-12-03 08:46:37 UTC
It seems like this was done in 96bc1972 so it can be closed.

commit 96bc19725c88ed30238e6b29b0ea364e955b5ae3
Author: Darcy Bras da Silva <dardevelin.cidadecool.com>
Date:   Sun Sep 30 12:46:42 2012 +0100

    add repeat, no-repeat, shuffle, no-shuffle to rhythmbox-client

 remote/dbus/rb-client.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 58 insertions(+), 1 deletion(-)
Comment 5 Jonathan Matthew 2012-12-08 07:43:51 UTC
Indeed, thanks for pointing that out.