After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 381132 - Evolution should use system timezone settings
Evolution should use system timezone settings
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[timezone]
: 251361 574219 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-12-01 02:51 UTC by Li Yuan
Modified: 2010-10-29 13:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
proposed eds patch (15.60 KB, patch)
2009-03-30 16:58 UTC, Milan Crha
committed Details | Review
proposed evo patch (27.16 KB, patch)
2009-03-30 17:15 UTC, Milan Crha
reviewed Details | Review
proposed evo patch ][ (27.71 KB, patch)
2009-04-15 11:12 UTC, Milan Crha
committed Details | Review

Description Li Yuan 2006-12-01 02:51:26 UTC
Evolution should use system timezone instead of its own timezone settings.
Comment 1 André Klapper 2006-12-01 16:14:50 UTC
no, because it can happen that you're in another timezone when travelling with your laptop.
Comment 2 Li Yuan 2006-12-04 03:15:13 UTC
So if I travel to another timezone, I should change my Evolution timezone and do not change my system timezone?
Comment 3 Crispin Cowan 2007-03-14 18:12:44 UTC
When I am *planning* travel to another time zone, it is convenient to be able to switch Evolution to that time zone without switching my whole laptop to that time zone.

Please do NOT change current behavior. It is fine the way it is, and if it worked the way OP requested, I would call it a bug.
Comment 4 Calvin Walton 2007-03-19 06:05:15 UTC
If Evolution retains the ability to choose a custom time zone, it should still use the system time zone information instead of its own internal copy - that way if the distro updates system time zone info when Evolution hasn't, things don't get out of sync
Comment 5 Paul Smith 2007-11-01 13:14:23 UTC
I think (hope) that what the OP was asking was for Evolution to use the timezone information from the system, rather than having its own complete (incompatible) copy of timezone data--especially since the Evolution version is constantly out of date!

Whether Evo uses the actual timezone settings from the system or not is another question; I agree it would be nice to have Evo initialize the timezone settings from the system rather than asking the user when it first comes up, but it should be possible to change Evo's settings without changing the system settings.

But that doesn't have anything to do with where Evo gets timezone info from.

This is probably best marked as a duplicate of bug #301363
Comment 6 Egon Kocjan 2008-02-02 18:29:22 UTC
I would probably be optimal, if we had two settings:
- use system time zone (and use it as a default and not bother everyone when doing initial setup)
- use evolution specific time zone for those who prefer it
Comment 7 Pavel Šefránek 2008-03-24 09:07:30 UTC
Andre: now, when we have the shiny new clock applet, you can easy switch between timezones within it.
Comment 8 Tom Haddon 2008-04-22 23:09:00 UTC
Pavel, when you change system timezone with the international clock applet, this doesn't change the timezone in Evolution (at least for me on Hardy RC). I consider this a bug. I realise Crispin would consider it a bug if Evolution changed with his system timezone, but I suspect the majority of people would prefer it to change with the system timezone. 

I think the solution as mentioned would be to have two settings, one to set a timezone manually, and one to sync it to whatever the system time is.
Comment 9 Akhil Laddha 2008-08-04 10:32:19 UTC
Integration with system time zone had been done in Evolution 2.12. Can we close the bug ?  TIA.
Comment 10 Sebastien Bacher 2008-08-05 07:51:12 UTC
what do you call system timezone integration? GNOME 2.22 still had this issue, reopening the bug
Comment 11 Jim Rorie 2008-10-15 15:26:55 UTC
I can confirm that 2.22 still has this issue.  Now that the clock applet allows you to change zones quicker and more efficiently that evolution, this "feature" is not only redundant, but potentially dangerous.  An individual that isn't familiar with TZ under evolution will miss appointments after changing the system TZ, assuming that all applications will get the change.
Comment 12 Milan Crha 2009-03-30 16:58:49 UTC
Created attachment 131711 [details] [review]
proposed eds patch

for evolution-data-server;

Most of this code is based on gnome-panel's clock-applet's system-timezone.c.
New API functions included.
Comment 13 Milan Crha 2009-03-30 17:15:52 UTC
Created attachment 131714 [details] [review]
proposed evo patch

for evolution;

evolution's part. No timezone configuration in the first setup wizard for a timezone, sets "use system timezone" instead. Added some widgets to be able to check/uncheck this in preferences.
Two things:
- I do not know how to listen for system timezone change
- I noticed some similar behaviour like in bug #573866 when
  checking/unchecking "quickly". I do not know why.
Comment 14 Chenthill P 2009-04-15 07:32:40 UTC
Once the 'Use system timezone' option is enabled, it would be good to set the existing gconf key "/apps/evolution/calendar/display/timezone" to system timezone. I say this since all the components watch for changes in this key.

Marcus banes line shows a wrong time when i select this option, though both my system timezone and timezone set in evolution are the same. I suspect this might be fixed by setting the above gconf key. 

The Checkbox for 'Use system timezone' could come under Timezone  combo for better alignment. The current alignment does not look so good. 

All the EDS changes seems fine. The evolution part needs to be looked a bit so the timezone changes propogates well.

Would it better to watch for the changes in /etc/locatime file? Am not sure, need to think about the best way.
Comment 15 Milan Crha 2009-04-15 10:16:22 UTC
(In reply to comment #14)
> Once the 'Use system timezone' option is enabled, it would be good to set the
> existing gconf key "/apps/evolution/calendar/display/timezone" to system
> timezone. I say this since all the components watch for changes in this key.

I didn't want to do this, rather have it easier for users to have their timezone remembered, thus when unchecking "use system timezone" they will not be forced to find the timezone again.

> Marcus banes line shows a wrong time when i select this option, though both my
> system timezone and timezone set in evolution are the same. I suspect this
> might be fixed by setting the above gconf key. 

I'll look at this.

> The Checkbox for 'Use system timezone' could come under Timezone  combo for
> better alignment. The current alignment does not look so good. 

The way I ordered it is by preference/logic, because the combo doesn't influence checkbox, but checkbox influences combo.
Comment 16 Milan Crha 2009-04-15 11:12:55 UTC
Created attachment 132684 [details] [review]
proposed evo patch ][

for evolution;

Moved "time zone" label one row up, instead of changing order of the checkbox an the combo.

Checked the Marcus Bain line issue, and it doesn't happen to me always, but as I thought, it's the issue of bug #573866. When I add debug prints to read and write functions of use_system_timezone, then I see I wrote TRUE, but the next read returned FALSE or vice versa. Usually works fine, though.

Also added calendar_config_get_timezone_stored, which returns the timezone stored in a gconf, so the preferences dialog will show the timezone which is stored, not the one actually in use.
Comment 17 Chenthill P 2009-04-21 08:25:22 UTC
Please commit the patches to trunk.
Comment 18 Milan Crha 2009-04-24 17:14:04 UTC
Created commit 3ea36b6 in eds master.
Created commit c33335b in evo master.
Comment 19 Milan Crha 2010-09-30 09:05:38 UTC
*** Bug 251361 has been marked as a duplicate of this bug. ***
Comment 20 Milan Crha 2010-10-29 13:19:53 UTC
*** Bug 574219 has been marked as a duplicate of this bug. ***