GNOME Bugzilla – Bug 379063
Manually editing library_layout_filename or library_layout_path results in the value being cleared
Last modified: 2018-05-24 12:05:38 UTC
Please describe the problem: Using the gconf editor to manually edit library_layout_filename or library_layout_path should work the same way as manually editing library_locations or rhythmdb_columns_setup, for example. Steps to reproduce: 1. Make sure rythmbox is running 2. Change /apps/rhythmbox/library_layout_filename to a nonstandard value, say, %tN - %ta - %tt (Alternately, manually editing /apps/rhythmbox/library_layout_path results in the same issue) Actual results: The value is cleared and becomes blank. Opening rhythmbox's preferences results in the 'File name' value appearing as empty and an available value must be selected, or the key reset to the default. Expected results: The custom value is retained, used, and exposed in the prefences GUI, like using multiple libraries or adding non-standard columns to the interface via the gconf editor. Does this happen every time? Yes Other information:
Confirming. Ideally there would be an "Other" in the drop-down list which would expose a text editing area.
Created attachment 77418 [details] [review] Handle custom library_layout_path This is a first cut to fix this for the path, based on UI feedback, I'll update this to include a similar fix for the path name
(In reply to comment #2) > I'll update this to include a similar fix for the path name I mean file name.
Created attachment 77423 [details] [review] Fix some subtle updating issues in previous patch
It's a reasonable idea, but it's not very useful unless you know the substitution variables you can use. I'm not sure how these could best be displayed, though. The custom hierarchy text box probably needs to be labeled. Not that this patch introduces the problem, but you end up with random garbage example paths if you type a prefix of a substitution variable. If the custom hierarchy you enter happens to match one of the predefined options, it's very difficult to edit it further. I had to restart it. The patch adds a line commented out with c++ comment style ("//gtk_entry_set_text"). We should do the same for the filename component too.
In commit 2c2f5c3 I fixed the problem where the pattern gets cleared. You still can't define a custom pattern through the UI, though.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/277.