GNOME Bugzilla – Bug 378759
crash in Evolution: I was sending email sign...
Last modified: 2007-09-24 13:49:54 UTC
What were you doing when the application crashed? I was sending email signed by S/MIME and I was asked for password. After filling the password the application crashed. Distribution: Ubuntu 6.10 (edgy) Gnome Release: 2.16.1 2006-10-02 (Ubuntu) BugBuddy Version: 2.16.0 Memory status: size: 301793280 vsize: 0 resident: 301793280 share: 0 rss: 59498496 rss_rlim: 0 CPU usage: start_time: 1164355857 rtime: 0 utime: 2265 stime: 0 cutime:1948 cstime: 0 timeout: 317 it_real_value: 0 frequency: 16583 Backtrace was generated from '/usr/bin/evolution-2.8' Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1". [Thread debugging using libthread_db enabled] [New Thread -1232804176 (LWP 22617)] [New Thread -1409324128 (LWP 23407)] [New Thread -1390335072 (LWP 22673)] [New Thread -1363870816 (LWP 22670)] [New Thread -1390068832 (LWP 22668)] [New Thread -1381651552 (LWP 22664)] [New Thread -1355256928 (LWP 22634)] [New Thread -1346663520 (LWP 22633)] [New Thread -1292964960 (LWP 22625)] [New Thread -1284572256 (LWP 22624)] 0xffffe410 in __kernel_vsyscall ()
+ Trace 88979
Thread 1 (Thread -1232804176 (LWP 22617))
Seems like pass_response is calling strcmp() on a null msg->key in there. Not sure why it is NULL though. Needs someone who knows the code to look at it.
Our "bad boy" here is support for pkcs11 and pkcs12 (in this case smime_pk11_passwd called e_passwords_ask_password with key=NULL).
Created attachment 94653 [details] [review] proposed eds patch for evolution-data-server; This is only a part of fix for this bug. I added check to e_passwords_ask_password on non-NULL component_name and key parameters, if someone pass either of those parameters as NULL, then for no password will be asked. This check has been done in all public functions, except this one. All other functions expects these values non-NULL.
Created attachment 94655 [details] [review] proposed evo patch for evolution; Fix in smime subdirectory. All other calls to e_passwords_* in evolution and evolution-data-server directories seem fine to me.
Commit to head.
eds part committed to trunk. Committed revision 8020. evo part committed to trunk. Committed revision 34144.
*** Bug 412027 has been marked as a duplicate of this bug. ***
*** Bug 428687 has been marked as a duplicate of this bug. ***