GNOME Bugzilla – Bug 377164
Strange numbers in GtkRecentChooserMenu
Last modified: 2007-02-10 13:25:31 UTC
The GtkRecentChooserMenu should not use pdata->loaded_items as a count to number the items but the count of really shown items. See attached screen shot.
Created attachment 76869 [details]
2007-02-08 Emmanuele Bassi <firstname.lastname@example.org>
* gtk/gtkrecentchoosermenu.c (idle_populate_func): Keep count
of the displayed items to build the menu items mnemonic instead
of the overall item count. (#377164)
(idle_populate_clean_up): Append a menu item if all the items
got filtered in the idle populate function. (#405696)
* tests/testrecentchoosermenu.c: Add a test for the
Please consider backporting this fix to the gtk-2-10 branch.
if someone gives it more testing in the unstable branch and verifies that the
bugs are indeed closed, I will.
I have tested the bug fix and can verify that it works.
Glade uses GtkRecentChooserMenu and suffers from this bug. After testing Glade with gtk+ trunk, the bug disappeared.
I tested GtkRecentChooserMenu under a variety of cases:
* An empty recents list
* Clearing the recents list
* Adding an item to the recents list
* Removing old items off the list by adding new items from another application
Created attachment 82272 [details]
Shows proper numbering in GtkRecentChooserMenu.
many thanks vincent, I've backported the fixes from trunk to the gtk-2-10 branch.