After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 376308 - Save modified images before using tools
Save modified images before using tools
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.9.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks: 452785
 
 
Reported: 2006-11-17 13:54 UTC by Michael Chudobiak
Modified: 2009-09-10 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Chudobiak 2006-11-17 13:54:46 UTC
If an unsaved image is open in the viewer and the user selects a function from the "Tools" menu, gthumb should ask whether to save the image (like it does when navigating away from the modified image).

Otherwise, unexpected effects can occur. For instance, the unsaved rotations performed with Image > Transforms may conflict with the Tools > Rotate functions. The Image > Transform functions work on the pixbuf in memory, the Tools > Rotate functions work on file(s).

Ultimately, this would finally allow us to move the Tools > Rotate functions (and perhaps Tools > Convert, Tools > Scale, etc) into the Image menu (and remove the corresponding existing Image functions), finally ending the confusing duplication of functions between the two menus.

This was originally discussed in bug 370013.

I think we need to modify:

gth_window_activate_action_tools_jpeg_rotate
gth_window_activate_action_tools_jpeg_rotate_right
gth_window_activate_action_tools_jpeg_rotate_left

and other functions to include something like

        if (gth_window_get_image_modified (window)) {
                GthViewer *viewer = (GthViewer*) window;
                ask_whether_to_save (viewer, load_image__image_saved_cb);
        }                                    ^^^ not sure about this

- Mike
Comment 1 Michael Chudobiak 2009-09-10 19:28:33 UTC
Should be fixed in ext branch.