After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374658 - [matroskamux] add tag writing support and implement releasing of request pads
[matroskamux] add tag writing support and implement releasing of request pads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.4
Other Linux
: Normal normal
: 0.10.5
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-13 12:44 UTC by Mark Nauwelaerts
Modified: 2006-11-15 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing additions. (11.49 KB, patch)
2006-11-13 12:51 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-11-13 12:44:14 UTC 
Some small enhancements for matroskamux:
- basic tag support (similar to matroskademux);
  e.g. including language tags for example for transcoding from dvd or so
- implement releasing a request pad
Comment 1 Mark Nauwelaerts 2006-11-13 12:51:29 UTC 
Created attachment 76476 [details] [review]
Patch implementing additions.

Admittedly, the use of collectpads necessitates some (hm) doing to get hands on tag events ...
Comment 2 Tim-Philipp Müller 2006-11-15 12:08:37 UTC 
Oh well, if there's no better way, what else can you do? :)

 2006-11-15  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts  <manauw at skynet be>

        * gst/matroska/matroska-mux.c: (gst_matroska_mux_add_interfaces),
        (gst_matroska_mux_class_init), (gst_matroska_pad_free),
        (gst_matroska_mux_reset), (gst_matroska_mux_handle_sink_event),
        (gst_matroska_mux_request_new_pad), (gst_matroska_mux_release_pad),
        (gst_matroska_mux_track_header), (gst_matroska_mux_start),
        (gst_matroska_mux_write_simple_tag), (gst_matroska_mux_finish):
        * gst/matroska/matroska-mux.h:
          Add basic tag writing support; implement releasing pads (#374658).

Thanks for the patch!