After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374479 - [PATCH] videomixer memleak fix and enhancement
[PATCH] videomixer memleak fix and enhancement
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.4
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-12 22:33 UTC by Mark Nauwelaerts
Modified: 2006-11-13 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Enhancement implementation patch. (8.33 KB, patch)
2006-11-12 22:35 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-11-12 22:33:16 UTC 
Videomixer uses GstCollectPads (instance):
- does not free this
- does not implement releasing a request pad
Comment 1 Mark Nauwelaerts 2006-11-12 22:35:51 UTC 
Created attachment 76450 [details] [review]
Enhancement implementation patch.

* Fix memleak by unref'ing collectpads instance (when finalizing)
* Implement releasing a request pad
Comment 2 Wim Taymans 2006-11-13 18:31:11 UTC 
        Patch by: Mark Nauwelaerts  <manauw at skynet be>

        * gst/videomixer/videomixer.c:
        (gst_videomixer_set_master_geometry),
        (gst_videomixer_pad_sink_setcaps), (gst_videomixer_class_init),
        (gst_videomixer_collect_free), (gst_videomixer_reset),
        (gst_videomixer_init), (gst_videomixer_finalize),
        (gst_videomixer_request_new_pad), (gst_videomixer_release_pad),
        (gst_videomixer_collected), (gst_videomixer_change_state):
        Fix memleak by unref'ing collectpads instance (when finalizing)
        Implement releasing a request pad. Fixes #374479.