After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369168 - Buffer overrun in camel-mime-filter-crlf.c
Buffer overrun in camel-mime-filter-crlf.c
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-11-02 00:49 UTC by Hans Petter Jansson
Modified: 2006-11-06 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix for CRLF filter buffer overrun. (888 bytes, patch)
2006-11-02 00:50 UTC, Hans Petter Jansson
committed Details | Review

Description Hans Petter Jansson 2006-11-02 00:49:24 UTC
There's a potential buffer overrun in the camel-mime-filter-crlf.c (CVS HEAD) code. I spotted this in practice using valgrind. I have a patch which should be self-explanatory.

I think this bug has been around since the early days.
Comment 1 Hans Petter Jansson 2006-11-02 00:50:35 UTC
Created attachment 75808 [details] [review]
Fix for CRLF filter buffer overrun.
Comment 2 Hans Petter Jansson 2006-11-02 03:56:55 UTC
I've confirmed that this bug does cause random real-life crashes too.
Comment 3 Harish Krishnaswamy 2006-11-02 06:19:18 UTC
Hans: The patch looks good - Thanks. I will commit this patch after adding a ChangeLog. Pl. do include ChangeLogs in future submissions. TIA.
Comment 4 Harish Krishnaswamy 2006-11-02 06:28:32 UTC
Patch committed to HEAD/Stable branch.
Comment 5 Veerapuram Varadhan 2006-11-02 11:02:08 UTC
Harish:  Can you commit it to 2.14 branch as well? (If anybody wants a 2.6.4 release would benefit from it).