GNOME Bugzilla – Bug 369053
search / replace dialog update
Last modified: 2011-05-27 11:16:50 UTC
I updated the glade file of the search / replace dialog. I used glade-3 to refresh it as glade-2 didn't seemed to be able to open it (!!??). Weird thing is in glade the 12px border is displayed but in gedit the border is not respected; as I don't understand why, I assume there is something on the gedit code, so I let you correct that :).
Created attachment 75793 [details] the new glade file I'm a nor an HIG specialist neither an hacker. I just hope this is useful.
Created attachment 75794 [details] the screenshot of the new dialog
Can you give a rationale to back up the changes? I think I prefer the current cleaner interface since the added verbosity doesn't add much information and just makes the dialog bigger which in turn means covering more of textview.
Hello Paolo, I assume the rationale means I have to provide arguments to give a chance to my changes :) Point 1, the rationale was to provide a consistent spacing between checkboxes with the GNOME desktop (6px), right the spacing doesn't respect the HIG recommandations. point 2, the dialog is not always bigger: - with the search dialog, the dialog is smaller (at least for me); - with the replace dialog, the dialog is smaller too but is seems the spacing between the bottom the dialog action were to big in the glade / screenshot provided. I corrected that. Dividing the options in two blocks was an advice of Steve Frecineaux, it is of course possible to change that I will post some screenshots with the before / after layout, and the new glade.
Created attachment 75822 [details] updated glade file
Actually, my proposition was meant to allow to try and position both two-options blocks side to side, i order to diminish the dialog heigth (which is definitely too big): +------------------------------------------------+ | Search for: _______________________________ | | Replace with: _______________________________ | | | | Matching: Cycling: | | [] match case [] wrap around | | [] entire words only [] search backward | +------------------------------------------------+
Created attachment 75896 [details] Try 3, with comments of Steve applied
Created attachment 75897 [details] Replace dialog in gedit
Created attachment 75898 [details] Search dialog in gedit
Created attachment 75900 [details] Updated glade again After discussion with Steve it appears the distance between bottom gtEntry and labels option (cycling or match ...) was too small. I've updated the glade. I won't update the screenshot right now, you just haev to doucle the space to figure out what the dialog looks like. :)
What do you think of a design similar to the mockup in http://bugzilla.gnome.org/show_bug.cgi?id=85606#c14 ? The Find/Replace buttons are in a column on the right side and there is room for a Help button. This basic layout is also used in Abiword and OpenOffice.org Writer. Personally, I would change the "search backwards" checkbox, (but keep the "wrap around" checkbox) and have a "Find previous" button as well as a "Find next" (cf. the Find bar in Epiphany and Evince). It's much quicker, navigation-wise.
Created attachment 156071 [details] [review] updated
I'm marking this as obsolete. Feel free to reopen if you provide an updated patch.