After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 368493 - Don't create toc sheet with absolute path / better error message
Don't create toc sheet with absolute path / better error message
Status: RESOLVED OBSOLETE
Product: nautilus-cd-burner
Classification: Deprecated
Component: cd-burner
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus CD Burner Maintainers
Nautilus CD Burner Maintainers
Depends on:
Blocks: 382368
 
 
Reported: 2006-10-31 19:40 UTC by Sven Arvidsson
Modified: 2009-07-29 10:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sven Arvidsson 2006-10-31 19:40:28 UTC
The toc file created when making a copy of an audio cd contains the full path to the iso file. This will create trouble if a user moves the files and later tries to burn them. Simply assuming that the iso file is in the same dir as the toc file would solve this problem.

On a similar note, when n-c-b notices that the iso/bin file is missing from the cue/toc file, the user gets a general error message with no real information. An error message informing the user about the missing file would be good, an open file dialogue window letting the user find the missing file would be even better.
Comment 1 William Jon McCann 2006-11-20 21:04:45 UTC
Yeah.  Any chance you can make a patch for this too?  :)
Comment 2 Sven Arvidsson 2006-11-22 15:09:16 UTC
I did a little more investigation, and it turns out that cdrdao is to blame for writing toc files with an absolute path. I will file a bug about this with them.

I can probably write a patch so n-c-b shows an error message when cdrdao can't find the toc / cue sheet. There are two error messages from cdrdao, related to this:

ERROR: Could not find input file "data.bin".
ERROR: Cannot open data file "/foo/bar/data.bin": No such file or directory

What's the best solution here, simply to add these strings to cdrdao_stderr_line and pass the error message on to the user?
Comment 3 William Jon McCann 2006-12-04 20:15:14 UTC
Yes that seems like a reasonable approach.  Please do file a bug with cdrdao and with your OS distro.  Thanks.
Comment 4 Sven Arvidsson 2006-12-26 20:06:29 UTC
There are three different error messages when dealing with missing files in cue / toc files. Depending on if cdrdao doesn't find the file, if the path is wrong and depending on if it's a data or audio image.

ERROR: Could not find input file "bootcd.bin".
ERROR: Track 1: Cannot open data file "/home/sa/data.bin": No such file or directory
ERROR: Track 1: Cannot open audio file "/home/sa/image.iso": No such file or directory

I actually tried to write a patch to check for these, but my meagre skills could only ever get the first string to be matched :)
Comment 5 Bastien Nocera 2009-07-29 10:45:57 UTC
nautilus-cd-burner has been replaced by Brasero in the GNOME 2.26 release. If your bug still applies to Brasero, please feel free to re-open the bug, and reassign it to brasero itself.