GNOME Bugzilla – Bug 367949
incorrect progress reported and incorrect total percent of copy wrong.
Last modified: 2014-06-16 08:12:52 UTC
select a directory in one pane, to be copied or moved to the other pane. use the function key F5 or F6. click Ok to copy or move and then the progress dialog box comes up. it displays 1 of 1 then 2 of 1...127 of 1, etc. You would expect it to copy 1 of 127, 2 of 127...127 of 127. But you have only selected 1 item, a directory--but the number of directories does not represent the number of items (of files) that you are copying/moving. A second anomaly in the same dialog box is that the percent done takes the size of the directory entry(1k?) as 100% and reports how much of that is copied. So if you have a directory with 1 meg of files in it, it reports 1000% completed, which is sort of silly if you think about it. I took a 10 second video (.mpg) of it so you could see what I mean.
Created attachment 75698 [details] short video of copy progress dialog box
No progress on this bug since 2006? It's quite an annoying one.
Confirmed on v1.2.8.2. The bug is totaly harmless, but makes the progress indicator basically useless.
*** Bug 626853 has been marked as a duplicate of this bug. ***
Created attachment 173137 [details] screen shot while copying - look at the small info panel
I got here an directory moved and ALL is completly wrong: First: [Datei 33 von 1] Second: 4.4 MB von 1024 k Third: At the beginning the panel said about 446900 % copied. Now it's struck at 0 %... - and totally worthless
Created attachment 213437 [details] [review] Correct feedback when moving files
As far as I can see, the problem is related to the GnomeVFS library (bugzilla product gnome-vfs): if gnome_vfs_async_xfer() is called with GnomeVFSXferOptions equal to GNOME_VFS_XFER_REMOVESOURCE, the GnomeVFSXferProgressInfo struct contains invalid data in fields files_total and bytes_total. Looks related to Bug 315336 (a bug filed in 2005, not solved yet apparently). I think the feedback when moving files should be correct. That means a couple of changes in gnome-cmd-xfer.cc: a) When moving files (xferOptions == GNOME_VFS_XFER_REMOVESOURCE), determine files_total and bytes_total in create_xfer_data(); b) Update these totals in async_xfer_callback() only if they increase A slightly altered calc_tree_size() (utils.cc) can be used to determine the totals. The function needs to: - return number of files as well as the byte count - also return valid data when the argument is not a directory
Jan, I checked the patch you committed nearly two years ago and everything works fine. I just had to insert two missing braces in utils.cc, line 792 and 796. Actually, the original bug occurs only when moving files in v1.4.1. Nevertheless, now GCMD displays the correct number of files and folders when moving them. Perfect and many thanks! The fix will go into the next bugfix release of GCMD.
*** Bug 466432 has been marked as a duplicate of this bug. ***
*** Bug 641220 has been marked as a duplicate of this bug. ***
*** Bug 680860 has been marked as a duplicate of this bug. ***
*** Bug 624281 has been marked as a duplicate of this bug. ***
*** Bug 644790 has been marked as a duplicate of this bug. ***