GNOME Bugzilla – Bug 364956
Caps incompatibilities for AMR
Last modified: 2006-10-25 17:20:53 UTC
Most amr elements use 'audio/AMR' as encoding name, but ffmux_mov rely on 'audio/x-amr-nb' encoding name.
Elements using 'audio/AMR' or 'audio/AMR-WB' :
Created attachment 75357 [details] [review]
change 'audio/AMR', 'audio/AMR-WB' to 'audio/x-amr-nb', 'audio/x-amr-wb' for gst-plugins-bad
Created attachment 75358 [details] [review]
same as previous patch for gst-plugins-good
Created attachment 75359 [details] [review]
same as previous patch for gst-plugins-ugly
attached patch modify encoding name to 'audio/x-amr-nb' and 'audio/x-amr-wb'
uhm... if most element use audio/AMR and only one element uses audio/x-amr-nb, maybe that would suggest that only one element is wrong...
But gst-ffmpeg is coherent for all its codec and many different elements too, encoding names mostly have a pattern 'media/x-name-other'.
I changed audio/x-amr-nb to audio/AMR because it is closer to an officially registered mime type and might therefore improve interoperability. I apparently forgot to change the ffmpeg muxer...
* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
Fix AMR caps. Fixes #364956.
* ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_get_stream):
Activate pads before adding them.