After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 364020 - totemMullYPlugin No support for previewimage param
totemMullYPlugin No support for previewimage param
Status: RESOLVED OBSOLETE
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on: 350297 363214 364022
Blocks:
 
 
Reported: 2006-10-21 20:25 UTC by Bastien Nocera
Modified: 2014-04-30 11:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
totem-kill-wrong-stream.patch (1.07 KB, patch)
2006-10-25 11:07 UTC, Bastien Nocera
needs-work Details | Review
first patch (4.57 KB, patch)
2006-11-15 21:09 UTC, Christian Persch
needs-work Details | Review

Description Bastien Nocera 2006-10-21 20:25:37 UTC
+++ This bug was initially created as a clone of Bug #363214 +++

There is no support for video/x-msvideo in totemMullYPlugin so this video don't play:
URL: http://www.pancrace.tv/


** Message: totem_plugin_new_instance
** Message: totemPlugin ctor [0xa25c628]
** Message: totemMullYPlugin ctor [0x9311898]
mode 1
mime type: video/divx
argv[0] type video/divx
argv[1] src free/demo.avi
argv[2] mode null
argv[3] autoplay false
argv[4] previewimage picts/PANCRACE-TV.jpg
argv[5] previewmessage Cliquez ici pour jouer la demo
argv[6] previewmessagefontsize 14
argv[7] allowcontextmenu false
argv[8] pluginspage http://go.divx.com/plugin/download/
argv[9] height 394
argv[10] width 512
** Message: plugin_get_value 14 (e)

** Message: SetWindow [0xa25c628]
** Message: waiting for data to come
** Message: leaving plugin_set_window
** Message: SetWindow [0xa25c628]
** Message: existing window
** Message: resize
** Message: leaving plugin_set_window
** Message: SetWindow [0xa25c628]
** Message: existing window
** Message: resize
** Message: leaving plugin_set_window
** Message: plugin_new_stream
** Message: plugin_new_stream type: video/x-msvideo url: http://www.pancrace.tv/free/demo.avi
** Message: Guessed mime-type 'video/x-msvideo' for 'http://www.pancrace.tv/free/demo.avi'
** Message: plugin_new_stream type: video/x-msvideo not supported, exiting

Other information:
Totem-CVS, Gstreamer-CVS, Gst-plugins-*-CVS and Gst-ffmpeg-CVS

The file play's fine in the standard Totem Movie Player when downloaded. But when streamed it have some audio problem (bug #362674).


We should support the previewimage and possibly previewmessage parameters.
Comment 1 Bastien Nocera 2006-10-22 22:27:46 UTC
That should help:

2006-10-22  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totemPlugin.cpp: gif and jpeg images are supported,
        rework the parameters parsing so that we are sure which order the
        parameters are parsed in (Closes: #364022), add the starts of
        imagepreview support for the DivX plugin

But we don't seem to be able to cancel (or tell apart!) the 2 streams that we would be creating: one created by the browser for the src, the other one created by ourselves. Any way to do that Christian?
Comment 2 Christian Persch 2006-10-22 22:47:42 UTC
Does this need 2 streams at the same time, or do we need to cancel the |src| stream and request a new one?
Comment 3 Bastien Nocera 2006-10-23 09:00:43 UTC
(In reply to comment #2)
> Does this need 2 streams at the same time, or do we need to cancel the |src|
> stream and request a new one?

The latter.
Comment 4 Bastien Nocera 2006-10-25 11:07:37 UTC
Created attachment 75360 [details] [review]
totem-kill-wrong-stream.patch

We seem to end up starving the viewer, as no data comes forth from the plugin, and the stdin input plugin for xine-lib is blocking.
Comment 5 Bastien Nocera 2006-10-25 11:12:07 UTC
I would prefer proactively disabling the stream before it's started, not sure whether that's possible.
Comment 6 Christian Persch 2006-10-25 11:27:30 UTC
My patch (wip) in bug 350297 will make this much easier.
Comment 7 Christian Persch 2006-11-15 21:09:20 UTC
Created attachment 76676 [details] [review]
first patch

Needs some work still... need to rework RequestStream to deal with this instead of adding RequestPreviewImage, I think.

Is there a better test URL? The previewimage from the URL in comment 0 is 404.
Comment 8 Bastien Nocera 2006-11-16 00:16:53 UTC
See test 1 in the new test suite :)
(test suite is a bit busted and hardcoded, feel free to report bugs in bug 361517)
Comment 9 Bastien Nocera 2014-04-30 11:21:54 UTC
The browser plugin has been removed from Totem. See this post for more details:
http://www.hadess.net/2014/04/good-bye-totem-browser-plugin.html