After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362854 - should migrate to new Gtk+ printing API
should migrate to new Gtk+ printing API
Product: gthumb
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 357902 (view as bug list)
Depends on:
Reported: 2006-10-17 13:22 UTC by Michael Chudobiak
Modified: 2006-12-08 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

First attempt to implement gtk-printing (52.49 KB, patch)
2006-12-06 13:54 UTC, Michael Chudobiak
none Details | Review
Second gtk-print attempt (53.33 KB, patch)
2006-12-08 14:09 UTC, Michael Chudobiak
none Details | Review
Final working patch. (54.12 KB, patch)
2006-12-08 20:18 UTC, Michael Chudobiak
none Details | Review

Description Michael Chudobiak 2006-10-17 13:22:11 UTC
gthumb currently uses libgnomeprint which is poorly maintained and poorly documented. The existing print dialogs are confusing (for instance, page orientation is set in two places), and missing some basic features (print multiple copies, collate).

gthumb should use the new Gtk+ printing API in the future. The basic API seems to handle all the basic features needed by gthumb: pages per sheet, number of copies, orientation, collation, etc.

See for details.

Porting the existing code to the new print system is way out of my league, but ping me if you want to try it! (I settled on gthumb as my viewer of choice because it had usable printing, unlike many other linux viewers.)

- Mike
Comment 1 Michael Chudobiak 2006-11-16 13:00:36 UTC
Update: this is being worked on... stay tuned...

- Mike
Comment 2 Michael Chudobiak 2006-11-16 13:01:50 UTC
*** Bug 357902 has been marked as a duplicate of this bug. ***
Comment 3 Michael Chudobiak 2006-12-06 13:54:12 UTC
Created attachment 77813 [details] [review]
First attempt to implement gtk-printing

OK, here is the first attempt to implement gtk-printing (rather than libgnomeprint).

It works quite well, except for one huge flaw: the images are rendered at 72 dpi, which looks horrible. (This is true of print-to-pdf, print-to-ps, and print-to-a-real-printer).

Right now, I don't know how to fix that. Help would be appreciated!

This patch was developed by Alex Pasca, with a few tweaks by me.

This patch applies to CVS HEAD.

- Mike
Comment 4 Michael Chudobiak 2006-12-08 14:09:19 UTC
Created attachment 77960 [details] [review]
Second gtk-print attempt

This patch now implements gtkprint, with output at 300 dpi.

There is a crasher bug when printing utf8 comments. It's being worked on.

- Mike
Comment 5 Michael Chudobiak 2006-12-08 20:18:30 UTC
Created attachment 77984 [details] [review]
Final working patch.

This patch seems to work well. I will be committing it.

- Mike