After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362603 - Fixes compiling with forte: warning clean up (part 4)
Fixes compiling with forte: warning clean up (part 4)
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-10-16 13:20 UTC by Josep Torra Valles
Modified: 2006-10-16 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

[patch] Fixes the bugs (18.22 KB, patch)
2006-10-16 13:21 UTC, Josep Torra Valles
needs-work Details | Review
[patch] Fixes the bugs (18.30 KB, patch)
2006-10-16 17:00 UTC, Josep Torra Valles
committed Details | Review

Description Josep Torra Valles 2006-10-16 13:20:42 UTC
Please describe the problem:
ext/cairo/gsttimeoverlay.c: arithmethics with a void pointer
ext/esd/esdsink.c: arithmethics with a void pointer
ext/flac/gstflacdec.c: wrong enumeration constants
ext/flac/gstflacenc.c: wrong enumeration constants
ext/jpeg/smokecodec.c: change DEBUG() for GST_DEBUG()
gst/avi/gstavimux.c: overflow
gst/debug/efence.c: arithmethics with a void pointer
gst/goom/ change GST_BASE_CFLAGS for GST_CFLAGS(-Werror)
gst/goom/gstgoom.c: diferent return type between declaration and definition
gst/icydemux/gsticydemux.c: wrong type
gst/rtsp/gstrtspsrc.c: right type is GstURIType
gst/rtsp/rtspconnection.c:HAVE_FIONREAD_IN_SYS_FILIO and arithmethics with a void pointer
gst/udp/gstudpsink.c: right type is GstURIType
gst/udp/gstudpsrc.c: right type is GstURIType
gst/wavparse/gstwavparse.c: (GstState) cast required
sys/sunaudio/gstsunaudiomixertrack.h: diferent type between declaration and definition

Steps to reproduce:
Compile it with Forte

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Josep Torra Valles 2006-10-16 13:21:34 UTC
Created attachment 74810 [details] [review]
[patch] Fixes the bugs
Comment 2 Tim-Philipp Müller 2006-10-16 15:41:37 UTC
Three small nitpicks:

 - config.h should always be included as very first file (rtspconnection.c patch)

 - why the removal of $(GST_BASE_CFLAGS) in gst/goom/ GstAdapter is used in goom code AFAICS. Maybe you just wanted to add $(GST_CFLAGS) ?

 - in smokedec/enc: there shouldn't be \n chars at the end of GST_DEBUG lines :)
Comment 3 Josep Torra Valles 2006-10-16 17:00:31 UTC
Created attachment 74826 [details] [review]
[patch] Fixes the bugs

With the changes suggested by Tim.
Comment 4 Tim-Philipp Müller 2006-10-16 18:23:14 UTC
Thanks a lot, committed:

 2006-10-16  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Josep Torra Valles  <josep at fluendo com>

        * ext/cairo/gsttimeoverlay.c: (gst_cairo_time_overlay_transform):
        * ext/esd/esdsink.c: (gst_esdsink_write):
        * ext/flac/gstflacdec.c: (gst_flac_dec_length),
        (gst_flac_dec_read_seekable), (gst_flac_dec_chain),
        * ext/flac/gstflacenc.c: (gst_flac_enc_seek_callback),
        * ext/jpeg/smokecodec.c: (find_best_size), (smokecodec_encode),
        (smokecodec_parse_header), (smokecodec_decode):
        * gst/avi/gstavimux.c: (gst_avi_mux_write_avix_index):
        * gst/debug/efence.c: (gst_fenced_buffer_alloc):
        * gst/goom/
        * gst/goom/gstgoom.c:
        * gst/icydemux/gsticydemux.c: (gst_icydemux_typefind_or_forward):
        * gst/rtsp/gstrtspsrc.c:
        * gst/rtsp/rtspconnection.c: (rtsp_connection_read):
        * gst/udp/gstudpsink.c:
        * gst/udp/gstudpsrc.c:
        * gst/wavparse/gstwavparse.c: (gst_wavparse_change_state):
        * sys/sunaudio/gstsunaudiomixertrack.h:
          Fix a bunch of problems discovered by the Forte compiler, mostly type
          mixups and pointer arithmetics with void pointers. Fixes #362603.

(removed that debug statement in gstwavparse altogether though).