Created attachment 74552 [details] [review]
drivel-set-font.patch

This patch is against HEAD and adds the ability to select a font.

This is important! I mean I can keep doing <font face=arial> texthere </font> until the end of time, but its a huge pain, and come on, why should it take until version 2.0.3+ to implement this simple feature.

I'll do some testing, see if it can get into 2.0.4 but I'm trying to limit the number of changes in 2.0.4 and put most into 2.1.1.

Original Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/drivel/+bug/83788

Whilst the font *is* changed in the text editor window, I'm unsure whether the intention was to change the rendered font in the posted entry - it certainly does not do that currently (test with movable-type).

Zachary - by the sounds of this, it does not solve your request which I read as passing <font> tags through to the blog posting. If you want that, you will need to continue using <font> or post a new bug report for this enhancement. (Which blogging software are you using?) I think the rendering font used by the actual blog site will need to be configured via the blog theme in many cases - there is little chance that the fonts installed on the system (and available in the text view via this patch) will match anything available on the server or even be mappable from one to the other. I don't see a way of being able to reliably edit in the same font as the site will use for display - especially when blogs support users changing the theme (e.g. serendipity).

However, the patch itself adds noise to the drivel output when changing the font:

(drivel:5821): GLib-GObject-WARNING **: unable to set property `text' of type `gchararray' from value of type `GdkPixbuf'
(drivel:5821): GLib-GObject-WARNING **: unable to set property `pixbuf' of type `GdkPixbuf' from value of type `gchararray'
(drivel:5821): Drivel-CRITICAL **: editor_set_font: assertion `font_name != NULL' failed

I'd like that cleaned up before including the patch, so unless the patch is updated, this won't happen in 2.0.4, postponing to 2.1 instead.

Testing with 2.1 (trunk), the patch needed some tweaks - mainly to the Glade file. Manual addition of the glade components from the patch causes build problems because of other changes required with glade-3 -> GtkBuilder etc.

Postponing until after the transitions are complete and the necessary Gtk elements can be included into the final GtkBuilder file instead of Glade.

Updated patch committed to SVN for 3.0 - some work may still be needed on the port of the added widgets to GtkBuilder.