After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361531 - Push extra metadata when adding new entries
Push extra metadata when adding new entries
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
Old
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 386558
Blocks: 375665 401049
 
 
Reported: 2006-10-11 19:24 UTC by Bastien Nocera
Modified: 2008-06-03 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
totem-pl-parser-push-extra-metadata.patch (5.86 KB, patch)
2007-01-29 14:24 UTC, Bastien Nocera 		needs-work Details | Review

Description Bastien Nocera 2006-10-11 19:24:55 UTC 
http://www.nwec.jp/vod/quicktime/505.qtl contains:

rtsptextrtsp://vod.nwec.jp/quicktime/505.mov
Type=video/quicktime
volume=80
autoplay=true

http://atvs.vg.no/player/player.php?id=5358&bandwidth=1804931&bandwidth_detected=1 (from bug 358277) contains:

   <Entry CLIENTSKIP="NO">
    <Title>Annonse</Title>
    <Author>VG Multimedia med Kroma & Aptoma NettTV</Author>
    <Copyright>(c) 2006 VG Multimedia AS</Copyright>
    <Abstract>Annonse</Abstract>
    <MoreInfo href=""/>
    <Ref href="http://atvs.vg.no/video/gfx/vg-tv.gif"/>
    <DURATION VALUE = "00:00:02" />
  </Entry>

We could pass things like the duration, autoplay, and volume to the front-ends.
Comment 1 Bastien Nocera 2007-01-29 14:24:49 UTC 
Created attachment 81434 [details] [review]
totem-pl-parser-push-extra-metadata.patch

An API changing patch.

We pass extra metadata as a GHashTable. Works fairly well in my tests (given the parsers have been updated as necessary, in this case, only the .qtl RTSPtextrtsp parser).
Comment 2 Bastien Nocera 2007-03-30 19:08:42 UTC 
Now done for the ASX and RTSPtext parsers in trunk. It breaks API compat.

2007-03-30  Bastien Nocera  <hadess@hadess.net>

        * configure.in: up libtool version

        * src/plparse/totem-pl-parser-pls.c:
        (totem_pl_parser_add_pls_with_contents):
        * src/plparse/totem-pl-parser-qt.c:
        (totem_pl_parser_add_quicktime_rtsptextrtsp):
        * src/plparse/totem-pl-parser-wm.c: (parse_asx_entry):
        * src/plparse/totem-pl-parser.c: (totem_pl_parser_class_init),
        (totem_pl_parser_init), (totem_pl_parser_add_url_valist),
        (totem_pl_parser_add_one_url):
        * src/plparse/totem-pl-parser.h:
        * src/plparse/totemplparser-marshal.list:
        Change the API to pass a metadata hashtable containing the
        extra metadata some players might require, like stream start time
        or still image duration

        * src/totem-playlist.c: (totem_playlist_entry_parsed),
        (totem_playlist_init):
        * src/plparse/test-parser.c: (entry_metadata_foreach),
        (entry_parsed), (test_parsing):
        * browser-plugin/totem-plugin-viewer.c: (entry_metadata_foreach),
        (entry_parsed), (totem_embedded_push_parser):
        Changes to reflect the API change

        (Closes: #361531)
Comment 3 Philip Withnall 2008-06-03 17:40:05 UTC 
Mass-move from totem to totem-pl-parser. You can remove all messages by searching for this comment.