GNOME Bugzilla – Bug 361071
score table is not updated with user name or score
Last modified: 2006-12-29 11:51:59 UTC
Please describe the problem: when a game ends in a "winning" time, the window opens, but the username and time are never listed. -- difficult mode Steps to reproduce: 1. finish a game in winning time 2. 3. Actual results: the window opens but there is no username, score or ony way to add them Expected results: see the username and score in the appropriate place in the list Does this happen every time? every time Other information: not a priority fix; however, seeing the list of scoring time is fun
I have seen this. Confirming.
*** Bug 362062 has been marked as a duplicate of this bug. ***
Fixing summary.
From the duplicate: "gnome-games-2.16.1/mahjongg/Makefile.am has: -for i in easy difficult confounding pyramid tictactoe cloud dragon bridges ziggurat; do \ touch $(DESTDIR)$(scoredir)/mahjongg.$$i.scores; \ chown $(scores_user):$(scores_group) $(DESTDIR)$(scoredir)/mahjongg.$$i.scores; \ chmod 664 $(DESTDIR)$(scoredir)/mahjongg.$$i.scores; \ done but mahjongg.map: <map name="Difficult" scorename="diff"> create mahjongg.diff.scores by hand and the scores are saved."
Created attachment 75689 [details] [review] Proposed patch. Simply replace "difficult" with "diff" in Makefile.am This produces the file mahjongg.diff.scores instead of mahjongg.difficult.scores.
*** Bug 371849 has been marked as a duplicate of this bug. ***
The proposed patch is the wrong way to do it. The high score file has always been known as difficult, changing it will effectively remove any old high scores. Instead I've changed the mahjongg.map file which has the faulty high score name in it. Andreas or Jason: should 2.16 be fixed too?
Andreas, since you are currently making the stable releases, I'll defer to your opinion.
Yes, I think that this patch should be backported to the 2.16 branch. Since there are now quite a lot of fixed bugs in the 2.16 branch since the previous stable release, I think that a relese of 2.16.1.1 should be done within the next few days.
*** Bug 390619 has been marked as a duplicate of this bug. ***