After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359986 - GnomeCC doesn't set former GConf key (for compatibility)
GnomeCC doesn't set former GConf key (for compatibility)
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: Sven Herzberg
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-05 19:08 UTC by Sven Herzberg
Modified: 2006-10-16 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed Patch (2.87 KB, patch)
2006-10-05 22:53 UTC, Sven Herzberg
none Details | Review
Proposed Patch (2.96 KB, patch)
2006-10-08 17:30 UTC, Sven Herzberg
none Details | Review
default-applications-legacy-gconf-key.patch (4.24 KB, patch)
2006-10-09 08:58 UTC, Luca Cavalli
none Details | Review
default-applications-legacy-gconf-key_2.patch (4.23 KB, patch)
2006-10-14 23:12 UTC, Luca Cavalli
committed Details | Review

Description Sven Herzberg 2006-10-05 19:08:13 UTC
I took a default Ubuntu installation, installed epiphany and made it the default browser via preferred apps.

Nautilus still opens firefox because /desktop/gnome/applications/browser/* is still set for firefox.

This path should be set as well.
Comment 1 Sven Herzberg 2006-10-05 19:51:59 UTC
I'm working on a fix, need to test it and then I will attach it for review.
Comment 2 Luca Cavalli 2006-10-05 20:21:12 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 169670 ***
Comment 3 Luca Cavalli 2006-10-05 20:27:34 UTC
I'm reworking a bit the Preferred Applications applet (see gnomecc-list archives) making it able to understand .desktop files, then it will be easy to set the selected web browser as the html and xhtml mime type handler.
Comment 4 Sven Herzberg 2006-10-05 22:38:08 UTC
Luca, this issue is NOT about file types. It's about URI handlers.
Comment 5 Sven Herzberg 2006-10-05 22:53:05 UTC
Created attachment 74098 [details] [review]
Proposed Patch

As Ubuntu doesn't want to install libnautilus-extensions-dev and I'm too lazy to dig for the option to disable themus, here's the untested patch.
Comment 6 Luca Cavalli 2006-10-05 22:57:46 UTC
Then, if this is a different bug, reopen it. Sorry, but when saw Nautilus I
thought at opening html/xhtml file types.
Comment 7 Sven Herzberg 2006-10-08 16:59:35 UTC
Reopening. Luca, can you take a look at this small patch please and tell whether it's okay to be committed? Thanks.
Comment 8 Christian Kellner 2006-10-08 17:15:23 UTC
Confirming.
Comment 9 Sven Herzberg 2006-10-08 17:30:35 UTC
Created attachment 74306 [details] [review]
Proposed Patch

This one actually compiles and works exactly as expected.
Comment 10 Sven Herzberg 2006-10-08 17:45:07 UTC
Okay, it doesn't fix the nautilus issue. But it should set this gconf key as well.
Comment 11 Luca Cavalli 2006-10-09 08:20:33 UTC
Given that the legacy gconf path /desktop/gnome/applications/browser/ is still used, your patch only sets the "exec" and "needs_term" keys. It doesn't fill the "nremote" key and there isn't an easy way to know if a browser supports this option (you could check for "openurl" in command line, but if not present it doesn't mean that the selected browser doesn't support nremote...). So, this seems to be a patch which doesn't completely fix the bug, even if applying it should be harmless and, maybe, better than nothing. Anyway, I can't give you the grant to apply the patch, you should ask Rodrigo or Sebastien.
Comment 12 Luca Cavalli 2006-10-09 08:26:55 UTC
Well, you have an *easy* way to know if nremote is supported. The XML has this information, so just use it :)
Comment 13 Luca Cavalli 2006-10-09 08:33:34 UTC
I have tested you patch (yes, I know, I should have post my comments after testing the patch, not before...) and it seems it doens't cut the command line in the correct way, since the %s is not always the first option, like in firefox -remote "openurl(%s,new-tab)".
Comment 14 Luca Cavalli 2006-10-09 08:58:48 UTC
Created attachment 74333 [details] [review]
default-applications-legacy-gconf-key.patch

This should strip the command line at the correct position and set nremote gconf key.
Comment 15 Sven Herzberg 2006-10-14 22:51:39 UTC
Looks fine (except the "Herzbergherzy" part :-D) and works for me.
Comment 16 Luca Cavalli 2006-10-14 23:12:47 UTC
Created attachment 74733 [details] [review]
default-applications-legacy-gconf-key_2.patch

Ops, sorry herzi. Damn cut & paste... :)
Comment 17 Rodrigo Moya 2006-10-16 11:39:56 UTC
Committed it myself for the 2.17.1 release