After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359751 - Add Support for libnotify Themes
Add Support for libnotify Themes
Status: RESOLVED WONTFIX
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.16.x
Other Linux
: Low trivial
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-04 23:36 UTC by Sven Herzberg
Modified: 2007-03-07 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-cc-notification-theme.patch (8.93 KB, patch)
2007-03-02 15:22 UTC, Luca Cavalli
reviewed Details | Review

Description Sven Herzberg 2006-10-04 23:36:42 UTC
see title
Comment 1 Christian Kellner 2006-10-04 23:40:36 UTC
Yepp, 100% agreed. I needed to go to gconf-editor to change that from Human to standard. (Which crased the daemon, but that is another issue). We definitely need support for that!
Comment 2 Rodrigo Moya 2006-10-05 08:14:13 UTC
hmm, and why not have libnotify use the configured theme color schemes?
Comment 3 Thomas Wood 2006-10-12 18:04:08 UTC
In fact, why not have libnotify use gtk themes in some way. I can't really see the justification of adding this to the theme manager for such a small part of the desktop. Can't libnotify just use a theme that matches the gtk+ theme name, if nothing else?
Comment 4 Thomas Wood 2006-10-27 15:27:53 UTC
Marking as WONTFIX, as I don't think this will ever be implemented in theme-manager.
Comment 5 Luca Cavalli 2007-03-02 15:22:04 UTC
Thomas, I totally agree with you if it was for notification colours, but the  daemon also needs to know which "theme engine" use to do the actual drawing. Since this engine is different from gtk+ one, the daemon needs its own gconf entry. I reopen the bug since I'm going to attach a patch. Feel free to close it again if you really think the notification theme engine selection doesn't belong to GNOME meta themes.
Comment 6 Luca Cavalli 2007-03-02 15:22:47 UTC
Created attachment 83735 [details] [review]
gnome-cc-notification-theme.patch
Comment 7 Thomas Wood 2007-03-02 18:21:56 UTC
I'm still not convinced. libnotify isn't even part of the platform yet, and even if/when it is, I don't believe adding support for every individual applications' custom theme method is a good idea.
Comment 8 Luca Cavalli 2007-03-05 09:27:06 UTC
yep, libnotify and notification daemon are not part of GNOME, but a lot of distros are shipping them and the library is used by some GNOME applications too, so I think it is much better to have such a hidden feature in meta themes, than another capplet just to select the engine to draw the notifications with.
Comment 9 Thomas Wood 2007-03-06 20:24:47 UTC
Why can't the notification daemon just select a theme engine of the same name as the current GTK+ theme?

I still don't believe the notification daemon should even be using it's own theme engine architecture. There are possible ways of doing this kind of specialised themeing within the GTK+ architecture.
Comment 10 Christian Kellner 2007-03-07 19:01:21 UTC
From a user point of view, and I am very much exactly that in this case, I am not really interested on if this is bound to the theme or if how its bound (automatically match the engines or using the same gtk theme engine) but as long as it isnt bound and as long as I have to switch it manually I want a easy way to configure it. My roommate was complaining about that so was my co-worker. So please lets get some done at all because developers of different components blaming the other developer to be responsible wont save the kittens! Please, please save the kittens! :-)
Comment 11 Luca Cavalli 2007-03-07 22:07:43 UTC
Adding Christian Hammond to the CC list.