After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 358613 - sink->file is never reset for filesink elements, even though pipeline goes to READY and back to PLAYING
sink->file is never reset for filesink elements, even though pipeline goes to...
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.11
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Reported: 2006-09-30 20:28 UTC by Fredrik Persson
Modified: 2006-10-02 09:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Fix (309 bytes, patch)
2006-09-30 20:29 UTC, Alessandro Decina
committed Details | Review

Description Fredrik Persson 2006-09-30 20:28:21 UTC
Please describe the problem:
If a filesink element is used at the end of a pipeline to store contents to file, it should be possible to set the state of the pipeline to READY, change the location property of the filesink element to a new file, and then set the state of the pipeline to PLAYING again, all this in order to store content to another file.

This does not work since the sink->file is never reset.

Steps to reproduce:
Run that tries to change the "location" property of a filesink element on a pipeline in READY state.

Actual results:
The warning: "WARNING **: Changing the `location' property on filesink when a file is open not supported." is given.

Expected results:
I would expect the filesink element to start storing content to the new file.

Does this happen every time?

Other information:
Comment 1 Alessandro Decina 2006-09-30 20:29:42 UTC
Created attachment 73714 [details] [review]
Comment 2 Wim Taymans 2006-10-02 09:43:24 UTC

        Patch by: Alessandro Decina  <alessandro at nnva org>

        * plugins/elements/gstfilesink.c: (gst_file_sink_init),
        (gst_file_sink_set_location), (gst_file_sink_open_file),
        (gst_file_sink_close_file), (gst_file_sink_event),
        Set file to NULL when closing filesink so that we can set a new filename
        in READY. Fixes #358613.